Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 1057043002: Don't return NativePages from Tab#getAllViews. (Closed)

Created:
5 years, 8 months ago by David Trainor- moved to gerrit
Modified:
5 years, 8 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't return NativePages from Tab#getAllViews. - Renamed the method to Tab#getAllContentViews to be more specific. - Prevent the method from returning NativePage views. BUG=462114 Committed: https://crrev.com/efde651eda85f3dda7ce7539d806d3a39cfebd27 Cr-Commit-Position: refs/heads/master@{#323917}

Patch Set 1 #

Patch Set 2 : Added old method back until downstream references are removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 1 chunk +13 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java View 1 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
David Trainor- moved to gerrit
ptal thanks
5 years, 8 months ago (2015-04-02 20:57:50 UTC) #2
newt (away)
lgtm. Do you need to keep the old method around for a little while to ...
5 years, 8 months ago (2015-04-02 21:04:05 UTC) #3
David Trainor- moved to gerrit
On 2015/04/02 21:04:05, newt wrote: > lgtm. > > Do you need to keep the ...
5 years, 8 months ago (2015-04-03 08:41:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057043002/20001
5 years, 8 months ago (2015-04-06 17:53:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-06 18:29:44 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 18:35:29 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/efde651eda85f3dda7ce7539d806d3a39cfebd27
Cr-Commit-Position: refs/heads/master@{#323917}

Powered by Google App Engine
This is Rietveld 408576698