Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4252)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java

Issue 1057043002: Don't return NativePages from Tab#getAllViews. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added old method back until downstream references are removed Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/Tab.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java
index 6d2c08ab214bc26014752a430942de352c9dbe3a..9be24e6040dc0919e5398a3dbe4fbaa66d22226f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java
@@ -221,15 +221,26 @@ public abstract class Layout implements TabContentManager.ThumbnailChangeListene
}
/**
+ * TODO(dtrainor): Remove after method is no longer used downstream.
* Used to get a list of Android {@link View}s that represent both the normal content as well as
* overlays.
* @param views A {@link List} that will be populated with {@link View}s that represent all of
* the content in this {@link Layout}.
*/
public void getAllViews(List<View> views) {
+ getAllContentViews(views);
+ }
+
+ /**
+ * Used to get a list of Android {@link View}s that represent both the normal content as well as
+ * overlays.
+ * @param views A {@link List} that will be populated with {@link View}s that represent all of
+ * the content in this {@link Layout}.
+ */
+ public void getAllContentViews(List<View> views) {
Tab tab = mTabModelSelector.getCurrentTab();
if (tab == null) return;
- tab.getAllViews(views);
+ tab.getAllContentViews(views);
}
/**
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/Tab.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698