Reconcile property tree and CDP layer skipping logic

Reconcile property tree and CDP layer skipping logic

BUG=477721
Committed: https://crrev.com/2175fae816052f4191c78c26c0c4f579a6ced5d3
Cr-Commit-Position: refs/heads/master@{#327124}

[Ian Vollick, 2015-04-27 18:39:09]

vollick@chromium.org changed reviewers:
+ ajuma@chromium.org

[ajuma, 2015-04-27 19:54:22]

lgtm

https://codereview.chromium.org/1056793009/diff/100001/cc/trees/draw_property...
File cc/trees/draw_property_utils.cc (right):

https://codereview.chromium.org/1056793009/diff/100001/cc/trees/draw_property...
cc/trees/draw_property_utils.cc:320: if (!!layer->parent() &&
SubtreeShouldBeSkipped(layer, layer_is_drawn))
Does removing the !! here trigger a compiler warning? (It seems weird to need
this in an if statement.)

https://codereview.chromium.org/1056793009/diff/100001/cc/trees/layer_tree_ho...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/1056793009/diff/100001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host_common_unittest.cc:9319: // Now, even though child has
zero opacity, we will configure _grandchild_ in
s/_grandchild_/|grandchild| (also below in the impl version of the test)

[Ian Vollick, 2015-04-27 20:13:05]

https://codereview.chromium.org/1056793009/diff/100001/cc/trees/draw_property...
File cc/trees/draw_property_utils.cc (right):

https://codereview.chromium.org/1056793009/diff/100001/cc/trees/draw_property...
cc/trees/draw_property_utils.cc:320: if (!!layer->parent() &&
SubtreeShouldBeSkipped(layer, layer_is_drawn))
On 2015/04/27 19:54:22, ajuma wrote:
> Does removing the !! here trigger a compiler warning? (It seems weird to need
> this in an if statement.)

Nope. Removed.

https://codereview.chromium.org/1056793009/diff/100001/cc/trees/layer_tree_ho...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/1056793009/diff/100001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host_common_unittest.cc:9319: // Now, even though child has
zero opacity, we will configure _grandchild_ in
On 2015/04/27 19:54:22, ajuma wrote:
> s/_grandchild_/|grandchild| (also below in the impl version of the test)

Done.

[Ian Vollick, 2015-04-27 20:13:34]

The CQ bit was checked by vollick@chromium.org

[Ian Vollick, 2015-04-27 20:13:34]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1056793009/#ps120001
(title: ".")

[commit-bot: I haz the power, 2015-04-27 20:14:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1056793009/120001

[commit-bot: I haz the power, 2015-04-27 21:18:20]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-04-27 21:19:16]

Patchset 7 (id:??) landed as
https://crrev.com/2175fae816052f4191c78c26c0c4f579a6ced5d3
Cr-Commit-Position: refs/heads/master@{#327124}