Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.cc

Issue 1056793002: Move clear cache code from chrome/ (ChromeWVGDelegate) to extensions/ (WVGuest) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-spbdr
Patch Set: fix test on windows Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/BUILD.gn ('k') | extensions/browser/guest_view/web_view/web_view_guest_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/web_view/web_view_guest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc
index f29e12f468018ec1b3693b94719a200c51325b6b..721cb11cac8d86967d8c61f5e73048f012723e6e 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc
@@ -7,6 +7,8 @@
#include "base/message_loop/message_loop.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
+#include "components/browsing_data/storage_partition_http_cache_data_remover.h"
+#include "components/web_cache/browser/web_cache_manager.h"
#include "content/public/browser/browser_context.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/child_process_security_policy.h"
@@ -705,15 +707,25 @@ bool WebViewGuest::ClearData(base::Time remove_since,
return false;
if (removal_mask & webview::WEB_VIEW_REMOVE_DATA_MASK_CACHE) {
- if (web_view_guest_delegate_) {
- // First clear http cache data and then clear the rest in
- // |ClearDataInternal|.
- web_view_guest_delegate_->ClearCache(
- remove_since, base::Bind(&WebViewGuest::ClearDataInternal,
- weak_ptr_factory_.GetWeakPtr(), remove_since,
- removal_mask, callback));
- return true;
- }
+ // First clear http cache data and then clear the rest in
+ // |ClearDataInternal|.
+ int render_process_id = web_contents()->GetRenderProcessHost()->GetID();
+ // We need to clear renderer cache separately for our process because
+ // StoragePartitionHttpCacheDataRemover::ClearData() does not clear that.
+ web_cache::WebCacheManager::GetInstance()->Remove(render_process_id);
+ web_cache::WebCacheManager::GetInstance()->ClearCacheForProcess(
+ render_process_id);
+
+ base::Closure cache_removal_done_callback = base::Bind(
+ &WebViewGuest::ClearDataInternal, weak_ptr_factory_.GetWeakPtr(),
+ remove_since, removal_mask, callback);
+ // StoragePartitionHttpCacheDataRemover removes itself when it is done.
+ // components/, move |ClearCache| to WebViewGuest: http//crbug.com/471287.
+ browsing_data::StoragePartitionHttpCacheDataRemover::CreateForRange(
+ partition, remove_since, base::Time::Now())
+ ->Remove(cache_removal_done_callback);
+
+ return true;
Fady Samuel 2015/04/26 15:06:07 I just noticed this early exit. What happens if yo
lazyboy 2015/04/26 15:16:51 ClearDataInternal above in |cache_removal_done_cal
}
ClearDataInternal(remove_since, removal_mask, callback);
« no previous file with comments | « extensions/browser/BUILD.gn ('k') | extensions/browser/guest_view/web_view/web_view_guest_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698