Source/modules/accessibility/AXNodeObject.h - Issue 1056763002: Reland: Made content editables report the caret and text selection by treating them as text controls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXNodeObject.h

Issue 1056763002: Reland: Made content editables report the caret and text selection by treating them as text controls (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/accessibility/AXLayoutObject.cpp ('K') | « Source/modules/accessibility/AXLayoutObject.cpp ('k') | Source/modules/accessibility/AXNodeObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXNodeObject.h

diff --git a/Source/modules/accessibility/AXNodeObject.h b/Source/modules/accessibility/AXNodeObject.h

index 759b4045ebd64aa0733be5bee0e3f3c1261c9366..de1164464215bb2190704f48819a7a460d74e2fe 100644

--- a/Source/modules/accessibility/AXNodeObject.h

+++ b/Source/modules/accessibility/AXNodeObject.h

@@ -67,7 +67,6 @@ protected:

void changeValueByStep(bool increase);

AccessibilityRole determineAriaRoleAttribute() const;

void elementsFromAttribute(WillBeHeapVector<RawPtrWillBeMember<Element>>& elements, const QualifiedName&) const;

- bool hasContentEditableAttributeSet() const;

// This returns true if it's focusable but it's not content editable and it's not a control or ARIA control.

bool isGenericFocusableElement() const;

HTMLLabelElement* labelForElement(Element*) const;