Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 105673006: Remove redundant test: COMPILER(GCC) || COMPILER(CLANG) => COMPILER(GCC) (Closed)

Created:
7 years ago by Nils Barth (inactive)
Modified:
7 years ago
Reviewers:
Nico
CC:
blink-reviews, yurys+blink_chromium.org, loislo+blink_chromium.org, adamk+blink_chromium.org, abarth-chromium, haraken, kouhei (in TOK)
Visibility:
Public.

Description

Remove redundant test: COMPILER(GCC) || COMPILER(CLANG) => COMPILER(GCC) COMPILER(CLANG) =implies=> COMPILER(GCC) so COMPILER(GCC) || COMPILER(CLANG) == COMPILER(GCC) Remove redundant and misleading test. Came up in: [POSSIBLE PERFORMANCE IMPACT] Use __builtin_expect on Clang as well (for UNLIKELY and LIKELY) https://codereview.chromium.org/114933002/ NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/wtf/Compiler.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Nils Barth (inactive)
Quick cleanup.
7 years ago (2013-12-13 04:57:10 UTC) #1
Nico
lgtm
7 years ago (2013-12-13 05:04:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/105673006/1
7 years ago (2013-12-13 05:10:24 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_python_tests, webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=20567
7 years ago (2013-12-13 07:30:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/105673006/1
7 years ago (2013-12-13 16:57:55 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-13 16:58:27 UTC) #6
Message was sent while issue was closed.
Change committed as 163876

Powered by Google App Engine
This is Rietveld 408576698