Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 1056713002: Revert of Fix GLSL error on Android. (Closed)

Created:
5 years, 8 months ago by rmistry
Modified:
5 years, 8 months ago
Reviewers:
bsalomon, Stephen White
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@filters-use-scratch-textures
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix GLSL error on Android. (patchset #2 id:20001 of https://codereview.chromium.org/1053873002/) Reason for revert: Spoke to Stephan about this. Reverting because failing debug builds: https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug/builds/51 https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Debug/builds/54 Original issue's description: > Fix GLSL error on Android. > > BUG=skia: > TBR=bsalomon > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/f90cd8e0e39af02c3826c80366efa3c06e88f642 TBR=bsalomon@google.com,senorblanco@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/fd40a249d814c3ca990422348266662a1521fb45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
rmistry
Created Revert of Fix GLSL error on Android.
5 years, 8 months ago (2015-04-01 22:50:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056713002/1
5 years, 8 months ago (2015-04-01 22:51:24 UTC) #2
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 22:51:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fd40a249d814c3ca990422348266662a1521fb45

Powered by Google App Engine
This is Rietveld 408576698