Issue 1056593002: Merge AppChildProcessHost into ChildProcessHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1056593002: Merge AppChildProcessHost into ChildProcessHost. (Closed)

Created:
5 years, 8 months ago by viettrungluu

Modified:
5 years, 8 months ago

Reviewers:
DaveMoore

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Merge AppChildProcessHost into ChildProcessHost. Simplify! (The same needs to be done on the child process side, i.e., AppChildProcess into ChildProcess.) More refactoring/cleanup to be done later (various TODOs added). R=davemoore@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2cdfa551fe4da6c67413d12aca1c03794ba2ad48

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+135 lines, -321 lines)			Patch
M	shell/BUILD.gn	View	2 chunks	+1 line, -3 lines	0 comments	Download
D	shell/app_child_process_host.h	View	1 chunk	+0 lines, -63 lines	0 comments	Download
D	shell/app_child_process_host.cc	View	1 chunk	+0 lines, -89 lines	0 comments	Download
D	shell/app_child_process_host_unittest.cc	View	1 chunk	+0 lines, -104 lines	0 comments	Download
M	shell/child_process_host.h	View	3 chunks	+37 lines, -18 lines	0 comments	Download
M	shell/child_process_host.cc	View	3 chunks	+64 lines, -8 lines	0 comments	Download
A +	shell/child_process_host_unittest.cc	View	4 chunks	+21 lines, -23 lines	0 comments	Download
M	shell/out_of_process_native_runner.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	shell/out_of_process_native_runner.cc	View	4 chunks	+10 lines, -11 lines	0 comments	Download

Total messages: 3 (0 generated)

viettrungluu

5 years, 8 months ago (2015-04-01 21:27:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2cdfa551fe4da6c67413d12aca1c03794ba2ad48 (presubmit successful).