Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: shell/child_process_host_unittest.cc

Issue 1056593002: Merge AppChildProcessHost into ChildProcessHost. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « shell/child_process_host.cc ('k') | shell/out_of_process_native_runner.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Note: This file also tests app_child_process.*. 5 // Note: This file also tests app_child_process.*.
6 6
7 #include "shell/app_child_process_host.h" 7 #include "shell/child_process_host.h"
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "base/message_loop/message_loop.h" 11 #include "base/message_loop/message_loop.h"
12 #include "mojo/common/message_pump_mojo.h" 12 #include "mojo/common/message_pump_mojo.h"
13 #include "mojo/public/c/system/types.h" 13 #include "mojo/public/c/system/types.h"
14 #include "mojo/public/cpp/system/message_pipe.h" 14 #include "mojo/public/cpp/system/message_pipe.h"
15 #include "shell/context.h" 15 #include "shell/context.h"
16 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
17 17
18 namespace mojo { 18 namespace mojo {
19 namespace shell { 19 namespace shell {
20 namespace { 20 namespace {
21 21
22 // Subclass just so we can observe |DidStart()|. 22 // Subclass just so we can observe |DidStart()|.
23 class TestAppChildProcessHost : public AppChildProcessHost { 23 class TestChildProcessHost : public ChildProcessHost {
24 public: 24 public:
25 explicit TestAppChildProcessHost(Context* context) 25 explicit TestChildProcessHost(Context* context) : ChildProcessHost(context) {}
26 : AppChildProcessHost(context) {} 26 ~TestChildProcessHost() override {}
27 ~TestAppChildProcessHost() override {}
28 27
29 void DidStart(bool success) override { 28 void DidStart(bool success) override {
30 EXPECT_TRUE(success); 29 EXPECT_TRUE(success);
31 AppChildProcessHost::DidStart(success); 30 ChildProcessHost::DidStart(success);
32 base::MessageLoop::current()->QuitWhenIdle(); 31 base::MessageLoop::current()->QuitWhenIdle();
33 } 32 }
34 33
35 private: 34 private:
36 DISALLOW_COPY_AND_ASSIGN(TestAppChildProcessHost); 35 DISALLOW_COPY_AND_ASSIGN(TestChildProcessHost);
37 }; 36 };
38 37
39 #if defined(OS_ANDROID) 38 #if defined(OS_ANDROID)
40 // TODO(qsr): Multiprocess shell tests are not supported on android. 39 // TODO(qsr): Multiprocess shell tests are not supported on android.
41 #define MAYBE_StartJoin DISABLED_StartJoin 40 #define MAYBE_StartJoin DISABLED_StartJoin
42 #else 41 #else
43 #define MAYBE_StartJoin StartJoin 42 #define MAYBE_StartJoin StartJoin
44 #endif // defined(OS_ANDROID) 43 #endif // defined(OS_ANDROID)
45 // Just tests starting the child process and joining it (without starting an 44 // Just tests starting the child process and joining it (without starting an
46 // app). 45 // app).
47 TEST(AppChildProcessHostTest, MAYBE_StartJoin) { 46 TEST(ChildProcessHostTest, MAYBE_StartJoin) {
48 Context context; 47 Context context;
49 base::MessageLoop message_loop( 48 base::MessageLoop message_loop(
50 scoped_ptr<base::MessagePump>(new common::MessagePumpMojo())); 49 scoped_ptr<base::MessagePump>(new common::MessagePumpMojo()));
51 context.Init(); 50 context.Init();
52 TestAppChildProcessHost app_child_process_host(&context); 51 TestChildProcessHost child_process_host(&context);
53 app_child_process_host.Start(); 52 child_process_host.Start();
54 message_loop.Run(); // This should run until |DidStart()|. 53 message_loop.Run(); // This should run until |DidStart()|.
55 app_child_process_host.ExitNow(123); 54 child_process_host.ExitNow(123);
56 int exit_code = app_child_process_host.Join(); 55 int exit_code = child_process_host.Join();
57 VLOG(2) << "Joined child: exit_code = " << exit_code; 56 VLOG(2) << "Joined child: exit_code = " << exit_code;
58 EXPECT_EQ(123, exit_code); 57 EXPECT_EQ(123, exit_code);
59 58
60 context.Shutdown(); 59 context.Shutdown();
61 } 60 }
62 61
63 #if defined(OS_ANDROID) 62 #if defined(OS_ANDROID)
64 // TODO(qsr): Multiprocess shell tests are not supported on android. 63 // TODO(qsr): Multiprocess shell tests are not supported on android.
65 #define MAYBE_ConnectionError DISABLED_ConnectionError 64 #define MAYBE_ConnectionError DISABLED_ConnectionError
66 #else 65 #else
67 #define MAYBE_ConnectionError ConnectionError 66 #define MAYBE_ConnectionError ConnectionError
68 #endif // defined(OS_ANDROID) 67 #endif // defined(OS_ANDROID)
69 // Tests that even on connection error, the callback to |StartApp()| will get 68 // Tests that even on connection error, the callback to |StartApp()| will get
70 // called. 69 // called.
71 TEST(AppChildProcessHostTest, MAYBE_ConnectionError) { 70 TEST(ChildProcessHostTest, MAYBE_ConnectionError) {
72 Context context; 71 Context context;
73 base::MessageLoop message_loop( 72 base::MessageLoop message_loop(
74 scoped_ptr<base::MessagePump>(new common::MessagePumpMojo())); 73 scoped_ptr<base::MessagePump>(new common::MessagePumpMojo()));
75 context.Init(); 74 context.Init();
76 TestAppChildProcessHost app_child_process_host(&context); 75 TestChildProcessHost child_process_host(&context);
77 app_child_process_host.Start(); 76 child_process_host.Start();
78 message_loop.Run(); // This should run until |DidStart()|. 77 message_loop.Run(); // This should run until |DidStart()|.
79 // Send |ExitNow()| first, so that the |StartApp()| below won't actually be 78 // Send |ExitNow()| first, so that the |StartApp()| below won't actually be
80 // processed, and we'll just get a connection error. 79 // processed, and we'll just get a connection error.
81 app_child_process_host.ExitNow(123); 80 child_process_host.ExitNow(123);
82 MessagePipe mp; 81 MessagePipe mp;
83 InterfaceRequest<Application> application_request; 82 InterfaceRequest<Application> application_request;
84 application_request.Bind(mp.handle0.Pass()); 83 application_request.Bind(mp.handle0.Pass());
85 // This won't actually be called, but the callback should be run. 84 // This won't actually be called, but the callback should be run.
86 MojoResult result = MOJO_RESULT_INTERNAL; 85 MojoResult result = MOJO_RESULT_INTERNAL;
87 app_child_process_host.StartApp( 86 child_process_host.StartApp("/does_not_exist/cbvgyuio", false,
88 "/does_not_exist/cbvgyuio", false, application_request.Pass(), 87 application_request.Pass(), [&result](int32_t r) {
89 [&result](int32_t r) { 88 result = r;
90 result = r; 89 base::MessageLoop::current()->QuitWhenIdle();
91 base::MessageLoop::current()->QuitWhenIdle(); 90 });
92 });
93 message_loop.Run(); 91 message_loop.Run();
94 EXPECT_EQ(MOJO_RESULT_UNKNOWN, result); 92 EXPECT_EQ(MOJO_RESULT_UNKNOWN, result);
95 int exit_code = app_child_process_host.Join(); 93 int exit_code = child_process_host.Join();
96 VLOG(2) << "Joined child: exit_code = " << exit_code; 94 VLOG(2) << "Joined child: exit_code = " << exit_code;
97 EXPECT_EQ(123, exit_code); 95 EXPECT_EQ(123, exit_code);
98 96
99 context.Shutdown(); 97 context.Shutdown();
100 } 98 }
101 99
102 } // namespace 100 } // namespace
103 } // namespace shell 101 } // namespace shell
104 } // namespace mojo 102 } // namespace mojo
OLDNEW
« no previous file with comments | « shell/child_process_host.cc ('k') | shell/out_of_process_native_runner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698