Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1056583002: Merge to XFA: doc.external - Check direction of property access before blindly getting. (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: doc.external - Check direction of property access before blindly getting. Original Review URL: https://codereview.chromium.org/1039063002 TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e49a260d35564553126dfa62ba03ead0892e7c75

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M fpdfsdk/src/javascript/Document.cpp View 4 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR'd merge.
5 years, 8 months ago (2015-04-01 17:12:38 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as e49a260d35564553126dfa62ba03ead0892e7c75 (presubmit successful).
5 years, 8 months ago (2015-04-01 17:12:51 UTC) #2
Lei Zhang
5 years, 8 months ago (2015-04-01 17:49:22 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698