Issue 1039063002: doc.external - Check direction of property access before blindly getting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1039063002: doc.external - Check direction of property access before blindly getting. (Closed)

Created:
5 years, 9 months ago by Tom Sepez

Modified:
5 years, 8 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

doc.external - Check direction of property access before blindly getting. BUG=https://code.google.com/p/pdfium/issues/detail?id=137 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/a1b7af074f3a4e15a1254b6df0c82baa4b012ae0

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -9 lines)			Patch
	M	fpdfsdk/src/javascript/Document.cpp	View		4 chunks	+4 lines, -9 lines	0 comments	Download

Total messages: 5 (1 generated)

Tom Sepez

Note to self: we should probably fix ASSERT() on linux first so that this fails ...

5 years, 9 months ago (2015-03-27 16:06:21 UTC) #4

Tom Sepez

5 years, 8 months ago (2015-04-01 16:50:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a1b7af074f3a4e15a1254b6df0c82baa4b012ae0 (presubmit successful).