Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1056543002: [turbofan][arm64] Match add with shifted operand for mult by a power of 2 plus 1. (Closed)

Created:
5 years, 8 months ago by baptiste.afsa1
Modified:
5 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan][arm64] Match add with shifted operand for mult by a power of 2 plus 1. R=bmeurer@chromium.org Committed: https://crrev.com/ba41489da55a3484ceb5ac84c07de546578a2161 Cr-Commit-Position: refs/heads/master@{#27612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -0 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M src/utils.h View 1 chunk +35 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
baptiste.afsa1
PTAL I observe some improvement on some hand crafted examples.
5 years, 8 months ago (2015-04-01 14:17:06 UTC) #1
Benedikt Meurer
lgtm
5 years, 8 months ago (2015-04-07 07:35:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056543002/1
5 years, 8 months ago (2015-04-07 08:26:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 08:48:20 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 08:48:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba41489da55a3484ceb5ac84c07de546578a2161
Cr-Commit-Position: refs/heads/master@{#27612}

Powered by Google App Engine
This is Rietveld 408576698