Issue 1056503002: Specify mojo_prebuilt_network_service_apptests_location via mojob.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1056503002: Specify mojo_prebuilt_network_service_apptests_location via mojob.py. (Closed)

Created:
5 years, 8 months ago by haltonhuo

Modified:
5 years, 8 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Specify mojo_prebuilt_network_service_apptests_location via mojob.py. How to use (take x86 for eg): ============================ $ mojo/tools/mojob.py gn --android --target-cpu=x86 \ --args="mojo_prebuilt_network_service_location=<x86_network_service_mojo_file> mojo_prebuilt_network_service_apptests_location=<x86_network_service_apptests_mojo_file>" $ mojo/tools/mojob.py build --android --target-cpu=x86 TEST=mojo/tools/android_mojo_shell.py --target-cpu="x86" mojo:network_service_apptests BUG=472609 R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d459e688a608f6eda850a23bb5e308a76ea51a47

Patch Set 1 #

Patch Set 2 : Add BUG info #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -6 lines)			Patch
	M	mojo/public/tools/BUILD.gn	View		1 chunk	+16 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

haltonhuo

This CL is working together with chromium CL https://codereview.chromium.org/1048413002/. It is needed otherwise, the arm ...

5 years, 8 months ago (2015-04-01 12:43:40 UTC) #1

qsr

5 years, 8 months ago (2015-04-02 08:59:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d459e688a608f6eda850a23bb5e308a76ea51a47 (presubmit successful).

Expand Messages | Collapse Messages