Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: net/quic/quic_client_session.h

Issue 1056263002: QUIC - Crash when there is a bad packet loss and the session is closed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_client_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_client_session.h
diff --git a/net/quic/quic_client_session.h b/net/quic/quic_client_session.h
index d465d657e87bb39be5d8c08b9e0a56fbd8d7bf6f..6b7dab68fdbf6e9f2d70fa44df6c1ad394a12b26 100644
--- a/net/quic/quic_client_session.h
+++ b/net/quic/quic_client_session.h
@@ -173,6 +173,11 @@ class NET_EXPORT_PRIVATE QuicClientSession : public QuicClientSessionBase,
// that this session has been closed, which will delete the session.
void CloseSessionOnError(int error, QuicErrorCode quic_error);
+ // Close the session because of |error| and notifies the factory later that
+ // this session has been closed, which will delete the session.
+ void CloseSessionOnErrorAndNotifyFactoryLater(int error,
+ QuicErrorCode quic_error);
+
base::Value* GetInfoAsValue(const std::set<HostPortPair>& aliases);
const BoundNetLog& net_log() const { return net_log_; }
@@ -207,6 +212,9 @@ class NET_EXPORT_PRIVATE QuicClientSession : public QuicClientSessionBase,
void OnClosedStream();
+ // Close the session because of |error| and records it in UMA histogram.
+ void RecordAndCloseSessionOnError(int error, QuicErrorCode quic_error);
+
// A Session may be closed via any of three methods:
// OnConnectionClosed - called by the connection when the connection has been
// closed, perhaps due to a timeout or a protocol error.
« no previous file with comments | « no previous file | net/quic/quic_client_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698