Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Unified Diff: net/quic/quic_client_session.cc

Issue 1056263002: QUIC - Crash when there is a bad packet loss and the session is closed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_client_session.h ('k') | net/quic/quic_stream_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_client_session.cc
diff --git a/net/quic/quic_client_session.cc b/net/quic/quic_client_session.cc
index e52b3c32d41344b2cbd55198bf9d75abc7bcb6a1..45cdcda0e683b24eaf0f73bd4a2525e85777021c 100644
--- a/net/quic/quic_client_session.cc
+++ b/net/quic/quic_client_session.cc
@@ -780,9 +780,21 @@ void QuicClientSession::StartReading() {
void QuicClientSession::CloseSessionOnError(int error,
QuicErrorCode quic_error) {
+ RecordAndCloseSessionOnError(error, quic_error);
+ NotifyFactoryOfSessionClosed();
+}
+
+void QuicClientSession::CloseSessionOnErrorAndNotifyFactoryLater(
+ int error,
+ QuicErrorCode quic_error) {
+ RecordAndCloseSessionOnError(error, quic_error);
+ NotifyFactoryOfSessionClosedLater();
+}
+
+void QuicClientSession::RecordAndCloseSessionOnError(int error,
+ QuicErrorCode quic_error) {
UMA_HISTOGRAM_SPARSE_SLOWLY("Net.QuicSession.CloseSessionOnError", -error);
CloseSessionOnErrorInner(error, quic_error);
- NotifyFactoryOfSessionClosed();
}
void QuicClientSession::CloseSessionOnErrorInner(int net_error,
« no previous file with comments | « net/quic/quic_client_session.h ('k') | net/quic/quic_stream_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698