[Telemetry] Remove interactive mode in page_test.

[Telemetry] Remove interactive mode in page_test.

This is the first step toward fixing https://code.google.com/p/chromium/issues/detail?id=470147.
I first needs make sure that all the logic for controlling page in page_test.RunPage()
can be moved to page.Run() (does not exist yet). This patch removes the interactive
run feature, since this is an instance of page_test but not page.

There are no exising page_test that I am aware of use this feature.

BUG=470147
Committed: https://crrev.com/075933c47b0a1b76d81708affdd9205c125ec699
Cr-Commit-Position: refs/heads/master@{#324919}

[nednguyen, 2015-04-03 23:20:59]

nednguyen@google.com changed reviewers:
+ aiolos@chromium.org, dtu@chromium.org

[nednguyen, 2015-04-07 21:50:27]

ping

[nednguyen, 2015-04-07 21:50:33]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-04-07 21:51:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1056213002/1

[commit-bot: I haz the power, 2015-04-07 22:05:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-07 22:05:16]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[aiolos (Not reviewing), 2015-04-07 22:28:28]

Interactive mode is meant for debugging failing benchmarks, and shouldn't be
specified anywhere other than the commandline.

Do we actually want to remove that feature? It's not useful very often, but I
have seen it help track down issues before.

[nednguyen, 2015-04-07 22:32:34]

On 2015/04/07 22:28:28, aiolos wrote:
> Interactive mode is meant for debugging failing benchmarks, and shouldn't be
> specified anywhere other than the commandline.
> 
> Do we actually want to remove that feature? It's not useful very often, but I
> have seen it help track down issues before.

If there is a particular page you want to add this "interactive feature" when
debugging, you can just write:

class PageFoo(...)
def RunPageInteractions(self):
   ....
   raw_input("Press Enter to continue..")
   ...

[aiolos (Not reviewing), 2015-04-07 22:34:46]

On 2015/04/07 22:28:28, aiolos wrote:
> Interactive mode is meant for debugging failing benchmarks, and shouldn't be
> specified anywhere other than the commandline.
> 
> Do we actually want to remove that feature? It's not useful very often, but I
> have seen it help track down issues before.

Or did you just mean to move this to the currently non-existent page.Run() ?
That would explain why you didn't remove the option from browser_options.

[nednguyen, 2015-04-07 22:47:22]

On 2015/04/07 22:34:46, aiolos wrote:
> On 2015/04/07 22:28:28, aiolos wrote:
> > Interactive mode is meant for debugging failing benchmarks, and shouldn't be
> > specified anywhere other than the commandline.
> > 
> > Do we actually want to remove that feature? It's not useful very often, but
I
> > have seen it help track down issues before.
> 
> Or did you just mean to move this to the currently non-existent page.Run() ?
> That would explain why you didn't remove the option from browser_options.

Err, I didn't notice that thing in browser_options. I will go ahead and remove
it there also.

[nednguyen, 2015-04-07 23:12:21]

On 2015/04/07 22:47:22, nednguyen wrote:
> On 2015/04/07 22:34:46, aiolos wrote:
> > On 2015/04/07 22:28:28, aiolos wrote:
> > > Interactive mode is meant for debugging failing benchmarks, and shouldn't
be
> > > specified anywhere other than the commandline.
> > > 
> > > Do we actually want to remove that feature? It's not useful very often,
but
> I
> > > have seen it help track down issues before.
> > 
> > Or did you just mean to move this to the currently non-existent page.Run() ?
> > That would explain why you didn't remove the option from browser_options.
> 
> Err, I didn't notice that thing in browser_options. I will go ahead and remove
> it there also.

PTAL

[nednguyen, 2015-04-13 20:11:20]

On 2015/04/07 23:12:21, nednguyen wrote:
> On 2015/04/07 22:47:22, nednguyen wrote:
> > On 2015/04/07 22:34:46, aiolos wrote:
> > > On 2015/04/07 22:28:28, aiolos wrote:
> > > > Interactive mode is meant for debugging failing benchmarks, and
shouldn't
> be
> > > > specified anywhere other than the commandline.
> > > > 
> > > > Do we actually want to remove that feature? It's not useful very often,
> but
> > I
> > > > have seen it help track down issues before.
> > > 
> > > Or did you just mean to move this to the currently non-existent page.Run()
?
> > > That would explain why you didn't remove the option from browser_options.
> > 
> > Err, I didn't notice that thing in browser_options. I will go ahead and
remove
> > it there also.
> 
> PTAL

PTAL again

[aiolos (Not reviewing), 2015-04-13 20:22:16]

On 2015/04/13 20:11:20, nednguyen wrote:
> On 2015/04/07 23:12:21, nednguyen wrote:
> > On 2015/04/07 22:47:22, nednguyen wrote:
> > > On 2015/04/07 22:34:46, aiolos wrote:
> > > > On 2015/04/07 22:28:28, aiolos wrote:
> > > > > Interactive mode is meant for debugging failing benchmarks, and
> shouldn't
> > be
> > > > > specified anywhere other than the commandline.
> > > > > 
> > > > > Do we actually want to remove that feature? It's not useful very
often,
> > but
> > > I
> > > > > have seen it help track down issues before.
> > > > 
> > > > Or did you just mean to move this to the currently non-existent
page.Run()
> ?
> > > > That would explain why you didn't remove the option from
browser_options.
> > > 
> > > Err, I didn't notice that thing in browser_options. I will go ahead and
> remove
> > > it there also.
> > 
> > PTAL
> 
> PTAL again

lgtm. We *might* want to consider adding this functionality back in if people
are using it more often than we are currently aware of.

[nednguyen, 2015-04-13 20:24:09]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2015-04-13 20:25:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1056213002/20001

[commit-bot: I haz the power, 2015-04-13 22:21:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-13 22:22:33]

Patchset 2 (id:??) landed as
https://crrev.com/075933c47b0a1b76d81708affdd9205c125ec699
Cr-Commit-Position: refs/heads/master@{#324919}