tools/telemetry/telemetry/page/page_test.py - Issue 1056213002: [Telemetry] Remove interactive mode in page_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_test.py

Issue 1056213002: [Telemetry] Remove interactive mode in page_test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove --interactive flag option from browser_options Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/page_test.py

diff --git a/tools/telemetry/telemetry/page/page_test.py b/tools/telemetry/telemetry/page/page_test.py

index bc5eb3e85e60ae77f44aba84fe24d6707d04914e..019f4929c8458125ef50f51f06ada0b8c9e789ac 100644

--- a/tools/telemetry/telemetry/page/page_test.py

+++ b/tools/telemetry/telemetry/page/page_test.py

@@ -207,14 +207,10 @@ class PageTest(object):

def RunPage(self, page, tab, results):

# Run actions.

- interactive = self.options and self.options.interactive

action_runner = action_runner_module.ActionRunner(

tab, skip_waits=page.skip_waits)

self.WillRunActions(page, tab)

- if interactive:

- action_runner.PauseInteractive()

- else:

- page.RunPageInteractions(action_runner)

+ page.RunPageInteractions(action_runner)

self.DidRunActions(page, tab)

self.ValidateAndMeasurePage(page, tab, results)

« no previous file with comments | « tools/telemetry/telemetry/core/browser_options.py ('k') | no next file » | no next file with comments »