Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1056093005: [turbofan] Split ControlEquivalence implementation and add trace flag. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years, 8 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Split ControlEquivalence implementation and add trace flag. Split interface and implementation of ControlEquivalence and add a dedicated trace flag --trace-turbo-ceq to make it reusable outside the scheduler. R=jarin@chromium.org Committed: https://crrev.com/d641cc457cdf07fa10d09de2f61fbbbfb3c36adb Cr-Commit-Position: refs/heads/master@{#27862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -200 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/control-equivalence.h View 6 chunks +16 lines, -200 lines 0 comments Download
A src/compiler/control-equivalence.cc View 1 chunk +237 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 8 months ago (2015-04-16 04:22:16 UTC) #1
Benedikt Meurer
Hey Jaro, Reducing linking/compile/inlining overhead for ControlEquivalence, and tracing independent of scheduler. Otherwise unchanged. Please ...
5 years, 8 months ago (2015-04-16 04:23:12 UTC) #2
Jarin
lgtm
5 years, 8 months ago (2015-04-16 06:02:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056093005/1
5 years, 8 months ago (2015-04-16 06:03:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 06:04:48 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 06:05:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d641cc457cdf07fa10d09de2f61fbbbfb3c36adb
Cr-Commit-Position: refs/heads/master@{#27862}

Powered by Google App Engine
This is Rietveld 408576698