Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1056023003: Add localized string and resource paths for media router WebUI. (Closed)

Created:
5 years, 8 months ago by mark a. foltz
Modified:
5 years, 8 months ago
CC:
chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add localized string and resource paths for media router WebUI. BUG=46422 TBR=jhawkins for .grdp Committed: https://crrev.com/b7c66b3f7d163c61330d05f397754bae8ddb3808 Cr-Commit-Position: refs/heads/master@{#327156}

Patch Set 1 #

Patch Set 2 : Adding stub media_router.html #

Patch Set 3 : Append new ID for media_router.html #

Total comments: 8

Patch Set 4 : Respond to apacible@ comments #

Total comments: 8

Patch Set 5 : Respond to bauerb@ comments. #

Patch Set 6 : Revert to camelCase string names. #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -7 lines) Patch
M chrome/app/media_router_strings.grdp View 1 2 3 4 5 6 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/media_router_resources.grdp View 1 2 3 4 5 6 2 chunks +5 lines, -1 line 0 comments Download
A chrome/browser/resources/media_router/media_router.html View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A + chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.h View 1 chunk +6 lines, -6 lines 0 comments Download
A chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc View 1 2 3 4 5 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/media_router/media_router_resources_provider.h View 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/media_router/media_router_resources_provider.cc View 1 2 3 4 1 chunk +95 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
mark a. foltz
5 years, 8 months ago (2015-04-23 17:47:59 UTC) #2
apacible
https://codereview.chromium.org/1056023003/diff/40001/chrome/app/media_router_strings.grdp File chrome/app/media_router_strings.grdp (right): https://codereview.chromium.org/1056023003/diff/40001/chrome/app/media_router_strings.grdp#newcode8 chrome/app/media_router_strings.grdp:8: <!-- Route Details --> I can bundle this with ...
5 years, 8 months ago (2015-04-23 20:43:31 UTC) #3
mark a. foltz
+bauerb for webui/OWNERS review. https://codereview.chromium.org/1056023003/diff/40001/chrome/app/media_router_strings.grdp File chrome/app/media_router_strings.grdp (right): https://codereview.chromium.org/1056023003/diff/40001/chrome/app/media_router_strings.grdp#newcode8 chrome/app/media_router_strings.grdp:8: <!-- Route Details --> On ...
5 years, 8 months ago (2015-04-23 23:17:53 UTC) #5
Bernhard Bauer
https://codereview.chromium.org/1056023003/diff/60001/chrome/app/media_router_strings.grdp File chrome/app/media_router_strings.grdp (right): https://codereview.chromium.org/1056023003/diff/60001/chrome/app/media_router_strings.grdp#newcode13 chrome/app/media_router_strings.grdp:13: Casting to How/where is this used? Simply concatenating localized ...
5 years, 8 months ago (2015-04-24 07:16:55 UTC) #6
mark a. foltz
https://codereview.chromium.org/1056023003/diff/60001/chrome/app/media_router_strings.grdp File chrome/app/media_router_strings.grdp (right): https://codereview.chromium.org/1056023003/diff/60001/chrome/app/media_router_strings.grdp#newcode13 chrome/app/media_router_strings.grdp:13: Casting to On 2015/04/24 07:16:54, Bernhard Bauer wrote: > ...
5 years, 8 months ago (2015-04-24 20:21:09 UTC) #7
mark a. foltz
@bauerb: Friendly ping when you get in :)
5 years, 8 months ago (2015-04-25 22:28:33 UTC) #8
Bernhard Bauer
LGTM with one nit, because I'm bad at explaining: https://codereview.chromium.org/1056023003/diff/60001/chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc File chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc (right): https://codereview.chromium.org/1056023003/diff/60001/chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc#newcode23 chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc:23: ...
5 years, 8 months ago (2015-04-27 08:41:46 UTC) #9
apacible
lgtm, thanks!
5 years, 8 months ago (2015-04-27 14:53:20 UTC) #10
mark a. foltz
https://codereview.chromium.org/1056023003/diff/60001/chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc File chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc (right): https://codereview.chromium.org/1056023003/diff/60001/chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc#newcode23 chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc:23: html_source->AddLocalizedString("backToSinkList", On 2015/04/27 08:41:45, Bernhard Bauer wrote: > On ...
5 years, 8 months ago (2015-04-27 19:38:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056023003/100001
5 years, 8 months ago (2015-04-27 19:41:42 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/46980) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-27 19:45:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056023003/120001
5 years, 8 months ago (2015-04-27 20:25:47 UTC) #19
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 8 months ago (2015-04-27 22:19:20 UTC) #20
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 22:20:33 UTC) #21
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/b7c66b3f7d163c61330d05f397754bae8ddb3808
Cr-Commit-Position: refs/heads/master@{#327156}

Powered by Google App Engine
This is Rietveld 408576698