chrome/app/media_router_strings.grdp - Issue 1056023003: Add localized string and resource paths for media router WebUI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/app/media_router_strings.grdp

Issue 1056023003: Add localized string and resource paths for media router WebUI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to apacible@ comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Media Router-specific strings (included from generated_resources.grd). -->	2 <!-- Media Router-specific strings (included from generated_resources.grd). -->

3 <grit-part>	3 <grit-part>

4 <message name="IDS_MEDIA_ROUTER_TITLE" desc="Title for media router">	4 <message name="IDS_MEDIA_ROUTER_TITLE" desc="Title for media router">

5 Media Router	5 Media Router

6 </message>	6 </message>

	7

	8 <!-- Route Details -->

	9 <message name="IDS_MEDIA_ROUTER_BACK_TO_SINK_PICKER" desc="Label of back to si nk picker button.">

	10 Back to device list

	11 </message>

	12 <message name="IDS_MEDIA_ROUTER_CASTING_ACTIVITY_STATUS" desc="Label of activi ty status.">

	13 Casting to
	Bernhard Bauer 2015/04/24 07:16:54 How/where is this used? Simply concatenating local How/where is this used? Simply concatenating localized strings might not work in all locales. Instead you should use a placeholder (e.g. <ph name="device">$1<ex>Chromecast</ex></ph>) and loadTimeData.getStringF(deviceName) in Javascript. This will also help translators, as they will see the whole sentence. mark a. foltz 2015/04/24 20:21:09 Changed to use a placeholder. This is used to sho Show quoted text On 2015/04/24 07:16:54, Bernhard Bauer wrote: > How/where is this used? Simply concatenating localized strings might not work in > all locales. Instead you should use a placeholder (e.g. <ph > name="device">$1<ex>Chromecast</ex></ph>) and > loadTimeData.getStringF(deviceName) in Javascript. This will also help > translators, as they will see the whole sentence. Changed to use a placeholder. This is used to show the user what the media device is doing, it's used here in our upstream repo: http://2-dot-cmrdiff.appspot.com/sidebyside?project=chrome_media_router&filen...
	14 </message>

	15 <message name="IDS_MEDIA_ROUTER_STOP_CASTING_BUTTON" desc="Text of Stop castin g button.">

	16 Stop casting

	17 </message>

7 </grit-part>	18 </grit-part>

OLD	NEW