Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 105593002: Add tests for C++ exception types that use virtual base classes (Closed)

Created:
7 years ago by Mark Seaborn
Modified:
7 years ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add tests for C++ exception types that use virtual base classes Matching an exception against a virtual base class requires dereferencing the exception and its vtable (unlike with non-virtual base classes), so this tests that the correct exception pointer is passed to exception_spec_can_catch() in libcxxabi (or check_exception_spec() in libsupc++). Also add a test to check that exception specs work when the exception is allowed by the exception spec. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3696 TEST=run_eh_throw_tests_sjlj_test Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12492

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -2 lines) Patch
M tests/toolchain/eh_throw_tests.cc View 4 chunks +82 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
7 years ago (2013-12-05 00:40:07 UTC) #1
Derek Schuff
lgtm
7 years ago (2013-12-05 01:21:31 UTC) #2
Mark Seaborn
7 years ago (2013-12-05 01:33:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r12492 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698