Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: lib/runtime/dart/convert.js

Issue 1055923002: Don't call dinvoke on Object methods (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Refactor dynamic target logic Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/runtime/dart/convert.js
diff --git a/lib/runtime/dart/convert.js b/lib/runtime/dart/convert.js
index 50b0b609d8eaed9d970539fd14dd841d617246f3..8322c636f42e769d839840de38bf880855b03688 100644
--- a/lib/runtime/dart/convert.js
+++ b/lib/runtime/dart/convert.js
@@ -30,7 +30,7 @@ var convert;
super.Codec();
}
decodeStream(byteStream) {
- return dart.as(byteStream.transform(dart.as(this.decoder, async.StreamTransformer$(core.List$(core.int), dynamic))).fold(new core.StringBuffer(), (buffer, string) => dart.dinvoke(buffer, 'write', string), buffer).then((buffer) => dart.dinvoke(buffer, 'toString')), async.Future$(core.String));
+ return dart.as(byteStream.transform(dart.as(this.decoder, async.StreamTransformer$(core.List$(core.int), dynamic))).fold(new core.StringBuffer(), (buffer, string) => dart.dinvoke(buffer, 'write', string), buffer).then((buffer) => buffer.toString()), async.Future$(core.String));
}
static getByName(name) {
if (name == null)
@@ -1532,13 +1532,13 @@ var convert;
return;
if (separator.isEmpty) {
do {
- this[_chunkedSink].add(dart.as(dart.dinvoke(iterator.current, 'toString'), core.String));
+ this[_chunkedSink].add(iterator.current.toString());
} while (iterator.moveNext());
} else {
- this[_chunkedSink].add(dart.as(dart.dinvoke(iterator.current, 'toString'), core.String));
+ this[_chunkedSink].add(iterator.current.toString());
while (iterator.moveNext()) {
this.write(separator);
- this[_chunkedSink].add(dart.as(dart.dinvoke(iterator.current, 'toString'), core.String));
+ this[_chunkedSink].add(iterator.current.toString());
}
}
}

Powered by Google App Engine
This is Rietveld 408576698