Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1618)

Unified Diff: lib/src/checker/rules.dart

Issue 1055923002: Don't call dinvoke on Object methods (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Refactor dynamic target logic Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/checker/resolver.dart ('k') | lib/src/utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/checker/rules.dart
diff --git a/lib/src/checker/rules.dart b/lib/src/checker/rules.dart
index 1cf9270e0c66f0c2035eedca0c8d38d44b493088..4d0317c2cbd0533f8c8e0e62f4671ccdd3758c6d 100644
--- a/lib/src/checker/rules.dart
+++ b/lib/src/checker/rules.dart
@@ -10,6 +10,7 @@ import 'package:analyzer/src/generated/resolver.dart';
import 'package:dev_compiler/src/info.dart';
import 'package:dev_compiler/src/options.dart';
+import 'package:dev_compiler/src/utils.dart' as utils;
abstract class TypeRules {
final TypeProvider provider;
@@ -45,7 +46,6 @@ abstract class TypeRules {
bool isDynamic(DartType t);
bool isDynamicTarget(Expression expr);
- bool isDynamicGet(Expression expr);
bool isDynamicCall(Expression call);
}
@@ -78,7 +78,6 @@ class DartRules extends TypeRules {
/// By default, all invocations are dynamic in Dart.
bool isDynamic(DartType t) => true;
bool isDynamicTarget(Expression expr) => true;
- bool isDynamicGet(Expression expr) => true;
bool isDynamicCall(Expression call) => true;
}
@@ -530,17 +529,8 @@ class RestrictedRules extends TypeRules {
bool isDynamic(DartType t) => options.ignoreTypes || t.isDynamic;
/// Returns `true` if the target expression is dynamic.
- bool isDynamicTarget(Expression expr) =>
- options.ignoreTypes || getStaticType(expr).isDynamic;
-
- /// Returns `true` if the expression is a dynamic property access or prefixed
- /// identifier.
- bool isDynamicGet(Expression expr) {
- if (options.ignoreTypes) return true;
- var t = getStaticType(expr);
- // TODO(jmesserly): we should not allow all property gets on `Function`
- return t.isDynamic || t.isDartCoreFunction;
- }
+ bool isDynamicTarget(Expression target) =>
Jennifer Messerly 2015/04/07 23:00:20 nice!!!
+ options.ignoreTypes || utils.isDynamicTarget(target);
/// Returns `true` if the expression is a dynamic function call or method
/// invocation.
« no previous file with comments | « lib/src/checker/resolver.dart ('k') | lib/src/utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698