lib/runtime/dart/_isolate_helper.js - Issue 1055923002: Don't call dinvoke on Object methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/runtime/dart/_isolate_helper.js

Issue 1055923002: Don't call dinvoke on Object methods (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: Refactor dynamic target logic Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/runtime/dart/_isolate_helper.js

diff --git a/lib/runtime/dart/_isolate_helper.js b/lib/runtime/dart/_isolate_helper.js

index b74a6dded4ca1da676d28b32ff92dcb3dce04da1..4eb067ea4fc2f3f4113b92cbc8b5aa6ff04d6d30 100644

--- a/lib/runtime/dart/_isolate_helper.js

+++ b/lib/runtime/dart/_isolate_helper.js

@@ -595,7 +595,7 @@ var _isolate_helper;

return;

}

let message = new core.List(2);

- message[core.$set](0, dart.dinvoke(error, 'toString'));

+ message[core.$set](0, error.toString());

message[core.$set](1, stackTrace == null ? null : stackTrace.toString());

for (let port of this.errorPorts)

port.send(message);

« no previous file with comments | « no previous file | lib/runtime/dart/_js_helper.js » ('j') | lib/src/checker/rules.dart » ('J')