chrome/browser/ui/views/website_settings/permissions_bubble_view.cc - Issue 1055883002: Fire an alert event to notify accessibility when a permissions bubble gets shown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

Issue 1055883002: Fire an alert event to notify accessibility when a permissions bubble gets shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adjust some output rules for ChromeVox. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('K') | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

index 3a77f05da2c3e0360ea0e9c1cc7d07ed39c0805a..d71c069e694d7ed488082249136e2b0f0ca27de6 100644

--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

@@ -445,6 +445,7 @@ void PermissionBubbleViewViews::Show(

views::BubbleDelegateView::CreateBubble(bubble_delegate_)->Show();

bubble_delegate_->SizeToContents();

+ bubble_delegate_->NotifyAccessibilityEvent(ui::AX_EVENT_ALERT, true);

dmazzoni 2015/04/02 20:29:20 I think you should do this in ui/views/bubble/bubb

David Tseng 2015/04/02 22:46:58 Not sure what you mean. I moved the alert notifica

}

bool PermissionBubbleViewViews::CanAcceptRequestUpdate() {