Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Side by Side Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

Issue 1055883002: Fire an alert event to notify accessibility when a permissions bubble gets shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust some output rules for ChromeVox. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/website_settings/permissions_bubble_view.h" 5 #include "chrome/browser/ui/views/website_settings/permissions_bubble_view.h"
6 6
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 427 matching lines...) Expand 10 before | Expand all | Expand 10 after
438 new PermissionsBubbleDelegateView( 438 new PermissionsBubbleDelegateView(
439 GetAnchorView(), GetAnchorArrow(), this, 439 GetAnchorView(), GetAnchorArrow(), this,
440 browser_->profile()->GetPrefs()->GetString(prefs::kAcceptLanguages), 440 browser_->profile()->GetPrefs()->GetString(prefs::kAcceptLanguages),
441 requests, values); 441 requests, values);
442 442
443 // Set |parent_window| because some valid anchors can become hidden. 443 // Set |parent_window| because some valid anchors can become hidden.
444 bubble_delegate_->set_parent_window(browser_->window()->GetNativeWindow()); 444 bubble_delegate_->set_parent_window(browser_->window()->GetNativeWindow());
445 445
446 views::BubbleDelegateView::CreateBubble(bubble_delegate_)->Show(); 446 views::BubbleDelegateView::CreateBubble(bubble_delegate_)->Show();
447 bubble_delegate_->SizeToContents(); 447 bubble_delegate_->SizeToContents();
448 bubble_delegate_->NotifyAccessibilityEvent(ui::AX_EVENT_ALERT, true);
dmazzoni 2015/04/02 20:29:20 I think you should do this in ui/views/bubble/bubb
David Tseng 2015/04/02 22:46:58 Not sure what you mean. I moved the alert notifica
448 } 449 }
449 450
450 bool PermissionBubbleViewViews::CanAcceptRequestUpdate() { 451 bool PermissionBubbleViewViews::CanAcceptRequestUpdate() {
451 return !(bubble_delegate_ && bubble_delegate_->IsMouseHovered()); 452 return !(bubble_delegate_ && bubble_delegate_->IsMouseHovered());
452 } 453 }
453 454
454 void PermissionBubbleViewViews::Hide() { 455 void PermissionBubbleViewViews::Hide() {
455 if (bubble_delegate_) { 456 if (bubble_delegate_) {
456 bubble_delegate_->Close(); 457 bubble_delegate_->Close();
457 bubble_delegate_ = nullptr; 458 bubble_delegate_ = nullptr;
(...skipping 18 matching lines...) Expand all
476 477
477 void PermissionBubbleViewViews::Accept() { 478 void PermissionBubbleViewViews::Accept() {
478 if (delegate_) 479 if (delegate_)
479 delegate_->Accept(); 480 delegate_->Accept();
480 } 481 }
481 482
482 void PermissionBubbleViewViews::Deny() { 483 void PermissionBubbleViewViews::Deny() {
483 if (delegate_) 484 if (delegate_)
484 delegate_->Deny(); 485 delegate_->Deny();
485 } 486 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698