Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 1055793004: Chromecast: updates crash keys entries. (Closed)

Created:
5 years, 8 months ago by gunsch
Modified:
5 years, 8 months ago
Reviewers:
lcwu1, reveman
CC:
chromium-reviews, gunsch+watch_chromium.org, kalyank, lcwu+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: updates crash keys entries. See: https://codereview.chromium.org/1028853002 R=reveman@chromium.org,lcwu@chromium.org BUG=None Committed: https://crrev.com/e65e41d9685d0efb7b28396d4efaf373f505524b Cr-Commit-Position: refs/heads/master@{#323873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chromecast/crash/cast_crash_keys.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
gunsch
5 years, 8 months ago (2015-04-02 22:34:36 UTC) #1
gunsch
On 2015/04/02 22:34:36, gunsch wrote: I wonder if there's a better long-term pattern to be ...
5 years, 8 months ago (2015-04-02 22:39:32 UTC) #2
gunsch
On 2015/04/02 22:39:32, gunsch wrote: > On 2015/04/02 22:34:36, gunsch wrote: > > I wonder ...
5 years, 8 months ago (2015-04-04 00:25:34 UTC) #3
reveman
lgtm
5 years, 8 months ago (2015-04-04 01:12:07 UTC) #4
reveman
lgtm
5 years, 8 months ago (2015-04-04 01:12:26 UTC) #5
lcwu1
lgtm
5 years, 8 months ago (2015-04-04 01:19:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055793004/1
5 years, 8 months ago (2015-04-04 03:00:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-04 03:32:30 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-04 03:33:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e65e41d9685d0efb7b28396d4efaf373f505524b
Cr-Commit-Position: refs/heads/master@{#323873}

Powered by Google App Engine
This is Rietveld 408576698