Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1028853002: content: Crash key and trace counter cleanup. (Closed)

Created:
5 years, 9 months ago by reveman
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Crash key and trace counter cleanup. Sort fixed_keys[] properly and improve the name of the crash keys to make it easy for someone not familiar with discardable memory to understand what they are. Also use TRACE_COUNTER1 instead of TRACE_COUNTER_ID1 for TotalDiscardableMemoryUsage as there should never be more than one of these per process. BUG= Committed: https://crrev.com/bab0737d3087f548e8bbe615adf5c83e2bcddc47 Cr-Commit-Position: refs/heads/master@{#321786}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M chrome/common/crash_keys.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M content/child/child_discardable_shared_memory_manager.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M content/common/host_discardable_shared_memory_manager.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
reveman
5 years, 9 months ago (2015-03-23 15:04:21 UTC) #2
Robert Sesek
LGTM
5 years, 9 months ago (2015-03-23 15:13:39 UTC) #3
Avi (use Gerrit)
lgtm
5 years, 9 months ago (2015-03-23 15:19:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028853002/20001
5 years, 9 months ago (2015-03-23 15:20:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-23 16:12:08 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 16:12:51 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bab0737d3087f548e8bbe615adf5c83e2bcddc47
Cr-Commit-Position: refs/heads/master@{#321786}

Powered by Google App Engine
This is Rietveld 408576698