Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1055683005: Revert of Require ECDHE for False Start. (Closed)

Created:
5 years, 8 months ago by alph
Modified:
5 years, 8 months ago
Reviewers:
agl, Ryan Sleevi, davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Require ECDHE for False Start. (patchset #4 id:60001 of https://codereview.chromium.org/1057733002/) Reason for revert: Suspecting guilty for broken Win link: http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/5998 Original issue's description: > Require ECDHE for False Start. > > This adds just enough of an implementation of ECDHE_RSA to tlslite to > support it on the server side. > > It also rolls BoringSSL e2e1326..4d78718 to pick up the corresponding > BoringSSL change. Summary of changes available at: > > https://boringssl.googlesource.com/boringssl/+log/e2e1326..4d78718 > > BUG=460271 TBR=agl@chromium.org,rsleevi@chromium.org,davidben@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=460271 Committed: https://crrev.com/2ed5b431af1276012941cefc3b947f6317b1dbaf Cr-Commit-Position: refs/heads/master@{#323697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -843 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 7 chunks +23 lines, -43 lines 0 comments Download
M net/ssl/ssl_cipher_suite_names.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/ssl/ssl_cipher_suite_names.cc View 9 chunks +39 lines, -66 lines 0 comments Download
M net/test/spawned_test_server/base_test_server.h View 1 chunk +3 lines, -4 lines 0 comments Download
M net/test/spawned_test_server/base_test_server.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/testserver/testserver.py View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/boringssl/boringssl.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/boringssl/boringssl_tests.gypi View 12 chunks +10 lines, -24 lines 0 comments Download
M third_party/boringssl/boringssl_unittest.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M third_party/boringssl/update_gypi_and_asm.py View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/tlslite/README.chromium View 2 chunks +1 line, -2 lines 0 comments Download
D third_party/tlslite/patches/ecdhe_rsa.patch View 1 chunk +0 lines, -428 lines 0 comments Download
M third_party/tlslite/tlslite/constants.py View 9 chunks +1 line, -44 lines 0 comments Download
M third_party/tlslite/tlslite/handshakesettings.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/tlslite/tlslite/messages.py View 4 chunks +2 lines, -16 lines 0 comments Download
M third_party/tlslite/tlslite/tlsconnection.py View 5 chunks +3 lines, -28 lines 0 comments Download
D third_party/tlslite/tlslite/utils/p256.py View 1 chunk +0 lines, -162 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
alph
Created Revert of Require ECDHE for False Start.
5 years, 8 months ago (2015-04-03 08:06:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055683005/1
5 years, 8 months ago (2015-04-03 08:08:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-03 08:09:28 UTC) #3
davidben
FYI, though the reland has this fixed, I was only able to reproduce in the ...
5 years, 8 months ago (2015-04-03 18:26:57 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:35:42 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ed5b431af1276012941cefc3b947f6317b1dbaf
Cr-Commit-Position: refs/heads/master@{#323697}

Powered by Google App Engine
This is Rietveld 408576698