cc: Adding testing for commits triggering NeedsBeginFrame when unable to draw.

cc: Adding testing for commits triggering NeedsBeginFrame.

This CL does two things;

 * Makes the commit requested test explicitly check that
   a commit only occurs during the impl frame.

 * Adds check for the case where commit is requested by
   can't draw.

This test was extracted from my original CL at
https://codereview.chromium.org/792803008/

BUG=346230
Committed: https://crrev.com/303b4f842223724c710b89cd342e9382e5c2b7a5
Cr-Commit-Position: refs/heads/master@{#324215}

[mithro-old, 2015-04-02 05:13:21]

mithro@mithis.com changed reviewers:
+ brianderson@chromium.org, sunnyps@chromium.org

[mithro-old, 2015-04-02 05:15:33]

Hi Sunny,

(CCing brianderson as an FYI.)

Can you take a look at this patch? Its a small addition to changes you made in
your webview refactor CL.

Tim 'mithro' Ansell

[sunnyps, 2015-04-07 23:28:27]

On 2015/04/02 05:15:33, mithro wrote:
> Hi Sunny,
> 
> (CCing brianderson as an FYI.)
> 
> Can you take a look at this patch? Its a small addition to changes you made in
> your webview refactor CL.
> 
> Tim 'mithro' Ansell

LGTM.

P.S. I don't have OWNERship or even committer status so I'm not sure if the CQ
will let this through with my LGTM.

[mithro-old, 2015-04-07 23:29:13]

The CQ bit was checked by mithro@mithis.com

[commit-bot: I haz the power, 2015-04-07 23:29:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1055673005/20001

[commit-bot: I haz the power, 2015-04-07 23:29:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-07 23:29:37]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[mithro-old, 2015-04-07 23:47:35]

I have OWNERs of cc/ so believe I just need an LGTM from someone.

On 8 April 2015 at 09:28, <sunnyps@chromium.org> wrote:

> On 2015/04/02 05:15:33, mithro wrote:
>
>> Hi Sunny,
>>
>
>  (CCing brianderson as an FYI.)
>>
>
>  Can you take a look at this patch? Its a small addition to changes you
>> made in
>> your webview refactor CL.
>>
>
>  Tim 'mithro' Ansell
>>
>
> LGTM.
>
> P.S. I don't have OWNERship or even committer status so I'm not sure if
> the CQ
> will let this through with my LGTM.
>
> https://codereview.chromium.org/1055673005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2015-04-07 23:48:37]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2015-04-07 23:48:38]

RS LGTM can you wrap your patch description at 72 chars?

[mithro-old, 2015-04-07 23:56:23]

The CQ bit was checked by mithro@mithis.com

[commit-bot: I haz the power, 2015-04-07 23:56:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1055673005/20001

[mithro-old, 2015-04-07 23:59:28]

The CQ bit was unchecked by mithro@mithis.com

[mithro-old, 2015-04-08 02:32:24]

The CQ bit was checked by mithro@mithis.com

[commit-bot: I haz the power, 2015-04-08 02:32:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1055673005/20001

[commit-bot: I haz the power, 2015-04-08 07:55:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-08 07:55:52]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mithro-old, 2015-04-08 09:10:53]

The CQ bit was checked by mithro@mithis.com

[commit-bot: I haz the power, 2015-04-08 09:11:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1055673005/20001

[commit-bot: I haz the power, 2015-04-08 11:56:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-08 11:57:06]

Patchset 2 (id:??) landed as
https://crrev.com/303b4f842223724c710b89cd342e9382e5c2b7a5
Cr-Commit-Position: refs/heads/master@{#324215}