extensions/common/api/idle.json - Issue 1055673002: [Extensions API] Remove inline enums

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/api/idle.json

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js ('K') | « extensions/common/api/extension_types.json ('k') | extensions/common/api/management.json » ('j') | extensions/common/api/management.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/api/idle.json

diff --git a/extensions/common/api/idle.json b/extensions/common/api/idle.json

index 153e931c4d0b9054aa2762adaa46a3527c22ac6c..43a9d071b6a01b3ae72c487b3738805c8be6d528 100644

--- a/extensions/common/api/idle.json

+++ b/extensions/common/api/idle.json

@@ -6,7 +6,13 @@

{

"namespace": "idle",

"description": "Use the <code>chrome.idle</code> API to detect when the machine's idle state changes.",

- "types": [],

+ "types": [

+ {

+ "id": "IdleState",

+ "type": "string",

+ "enum": ["active", "idle", "locked"]

+ }

+ ],

"functions": [

{

"name": "queryState",

@@ -25,8 +31,7 @@

"parameters": [

{

"name": "newState",

- "type": "string",

- "enum": ["active", "idle", "locked"]

+ "$ref": "IdleState"

}

]

}

@@ -54,8 +59,7 @@

"parameters": [

{

"name": "newState",

- "type": "string",

- "enum": ["active", "idle", "locked"]

+ "$ref": "IdleState"

}

]

}