[Extensions API] Remove inline enums

chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js

Index: chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js
diff --git a/chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js b/chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js
index fb46498773f01c97d6fa864dcd7424d71e9274e4..e8221c69e2dac124236e93a0e80c2d863b41667b 100644
--- a/chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js
+++ b/chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js
@@ -23,7 +23,7 @@ var builtinTypes = [
 
 function clobber(obj, name, qualifiedName) {
   // Clobbering constructors would break everything.
-  // Clobbering toString is annoying.
+  // Clobbering toString or substr is annoying.
   // Clobbering __proto__ breaks in ways that grep can't find.
   // Clobbering function name will break because
   // SafeBuiltins does not support getters yet. See crbug.com/463526.
@@ -31,6 +31,8 @@ function clobber(obj, name, qualifiedName) {
   // Clobbering Object.valueOf breaks v8.
   if (name == 'constructor' ||
       name == 'toString' ||
+      name == 'substr' ||

[Devlin, 2015/04/03 00:00:56]

Without these, we hit String.substr and Object.hasOwnProperty in the bindings
when creating the enums
(https://code.google.com/p/chromium/codesearch#chromium/src/extensions/rendere...).
 This strikes me as probably wrong... but this patch is just making that code
path trigger, not causing the bindings to execute anywhere differently. 
Thoughts?

[Devlin, 2015/04/03 19:38:50]

Resolved.

+      name == 'hasOwnProperty' ||
       name == '__proto__' ||
       name == 'name' && typeof obj == 'function' ||
       qualifiedName == 'Function.call' ||