tools/json_schema_compiler/test/callbacks.json - Issue 1055673002: [Extensions API] Remove inline enums

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/test/callbacks.json

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/test/callbacks.json

diff --git a/tools/json_schema_compiler/test/callbacks.json b/tools/json_schema_compiler/test/callbacks.json

index 2f86c26e15e07c36ee913b0798d6c59cab33f172..dbd03c30aa55d6a99b7d2cdd823cdab7b16d1c1c 100644

--- a/tools/json_schema_compiler/test/callbacks.json

+++ b/tools/json_schema_compiler/test/callbacks.json

@@ -2,7 +2,13 @@

{

"namespace": "callbacks",

"description": "The callbacks API.",

- "types": [],

+ "types": [

+ {

+ "id": "Enumeration",

+ "type": "string",

+ "enum": ["foo", "bar", "baz"]

+ }

+ ],

"functions": [

{

"name": "returnsNothing",

@@ -30,8 +36,7 @@

"type": "object",

"properties": {

"state": {

- "type": "string",

- "enum": ["foo", "bar", "baz"]

+ "$ref": "Enumeration"

}