Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: tools/json_schema_compiler/test/arrays_unittest.cc

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/json_schema_compiler/test/arrays.json ('k') | tools/json_schema_compiler/test/callbacks.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/json_schema_compiler/test/arrays_unittest.cc
diff --git a/tools/json_schema_compiler/test/arrays_unittest.cc b/tools/json_schema_compiler/test/arrays_unittest.cc
index 79ebfb2360e8b1d75a273432d323d342742f35a0..f0d3ab111291de042b9cf38c7b001f855a4c8d59 100644
--- a/tools/json_schema_compiler/test/arrays_unittest.cc
+++ b/tools/json_schema_compiler/test/arrays_unittest.cc
@@ -52,35 +52,6 @@ TEST(JsonSchemaCompilerArrayTest, BasicArrayType) {
}
}
-TEST(JsonSchemaCompilerArrayTest, EnumArrayType) {
- // { "types": ["one", "two", "three"] }
- base::ListValue* types = new base::ListValue();
- types->AppendString("one");
- types->AppendString("two");
- types->AppendString("three");
- base::DictionaryValue value;
- value.Set("types", types);
-
- EnumArrayType enum_array_type;
-
- // Test Populate.
- ASSERT_TRUE(EnumArrayType::Populate(value, &enum_array_type));
- {
- EnumArrayType::TypesType enums[] = {
- EnumArrayType::TYPES_TYPE_ONE,
- EnumArrayType::TYPES_TYPE_TWO,
- EnumArrayType::TYPES_TYPE_THREE,
- };
- std::vector<EnumArrayType::TypesType> enums_vector(
- enums, enums + arraysize(enums));
- EXPECT_EQ(enums_vector, enum_array_type.types);
- }
-
- // Test ToValue.
- scoped_ptr<base::Value> as_value(enum_array_type.ToValue());
- EXPECT_TRUE(value.Equals(as_value.get())) << value << " != " << *as_value;
-}
-
TEST(JsonSchemaCompilerArrayTest, EnumArrayReference) {
// { "types": ["one", "two", "three"] }
base::ListValue* types = new base::ListValue();
@@ -108,11 +79,6 @@ TEST(JsonSchemaCompilerArrayTest, EnumArrayReference) {
TEST(JsonSchemaCompilerArrayTest, EnumArrayMixed) {
// { "types": ["one", "two", "three"] }
- base::ListValue* inline_enums = new base::ListValue();
- inline_enums->AppendString("one");
- inline_enums->AppendString("two");
- inline_enums->AppendString("three");
-
base::ListValue* infile_enums = new base::ListValue();
infile_enums->AppendString("one");
infile_enums->AppendString("two");
@@ -124,7 +90,6 @@ TEST(JsonSchemaCompilerArrayTest, EnumArrayMixed) {
external_enums->AppendString("three");
base::DictionaryValue value;
- value.Set("inline_enums", inline_enums);
value.Set("infile_enums", infile_enums);
value.Set("external_enums", external_enums);
@@ -133,15 +98,6 @@ TEST(JsonSchemaCompilerArrayTest, EnumArrayMixed) {
// Test Populate.
ASSERT_TRUE(EnumArrayMixed::Populate(value, &enum_array_mixed));
- EnumArrayMixed::Inline_enumsType expected_inline_types[] = {
- EnumArrayMixed::INLINE_ENUMS_TYPE_ONE,
- EnumArrayMixed::INLINE_ENUMS_TYPE_TWO,
- EnumArrayMixed::INLINE_ENUMS_TYPE_THREE};
- EXPECT_EQ(std::vector<EnumArrayMixed::Inline_enumsType>(
- expected_inline_types,
- expected_inline_types + arraysize(expected_inline_types)),
- enum_array_mixed.inline_enums);
-
Enumeration expected_infile_types[] = {ENUMERATION_ONE, ENUMERATION_TWO,
ENUMERATION_THREE};
EXPECT_EQ(std::vector<Enumeration>(
@@ -164,16 +120,14 @@ TEST(JsonSchemaCompilerArrayTest, EnumArrayMixed) {
TEST(JsonSchemaCompilerArrayTest, OptionalEnumArrayType) {
{
- std::vector<OptionalEnumArrayType::TypesType> enums;
- enums.push_back(OptionalEnumArrayType::TYPES_TYPE_ONE);
- enums.push_back(OptionalEnumArrayType::TYPES_TYPE_TWO);
- enums.push_back(OptionalEnumArrayType::TYPES_TYPE_THREE);
+ std::vector<Enumeration> enums;
+ enums.push_back(ENUMERATION_ONE);
+ enums.push_back(ENUMERATION_TWO);
+ enums.push_back(ENUMERATION_THREE);
scoped_ptr<base::ListValue> types(new base::ListValue());
- for (size_t i = 0; i < enums.size(); ++i) {
- types->Append(new base::StringValue(
- OptionalEnumArrayType::ToString(enums[i])));
- }
+ for (size_t i = 0; i < enums.size(); ++i)
+ types->Append(new base::StringValue(ToString(enums[i])));
base::DictionaryValue value;
value.Set("types", types.release());
« no previous file with comments | « tools/json_schema_compiler/test/arrays.json ('k') | tools/json_schema_compiler/test/callbacks.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698