Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9072)

Unified Diff: chrome/common/extensions/api/debugger.json

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/cookies.json ('k') | chrome/common/extensions/api/extension.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/debugger.json
diff --git a/chrome/common/extensions/api/debugger.json b/chrome/common/extensions/api/debugger.json
index b08635ee5b6246ab4be52b1f917a26986463bf98..cf4e7b81d0e4ba2fb0ad4b7d437ca5f65961a77d 100644
--- a/chrome/common/extensions/api/debugger.json
+++ b/chrome/common/extensions/api/debugger.json
@@ -18,14 +18,25 @@
}
},
{
+ "id": "TargetInfoType",
+ "type": "string",
+ "description": "Target type.",
+ "enum" : ["page", "background_page", "worker", "other" ]
+ },
+ {
+ "id": "DetachReason",
+ "type": "string",
+ "description": "Connection termination reason.",
+ "enum": [ "target_closed", "canceled_by_user", "replaced_with_devtools" ]
+ },
+ {
"id": "TargetInfo",
"type": "object",
"description": "Debug target information",
"properties": {
"type": {
- "type": "string",
- "description": "Target type.",
- "enum" : ["page", "background_page", "worker", "other" ]
+ "$ref": "TargetInfoType",
+ "description": "Target type."
},
"id": { "type": "string", "description": "Target id." },
"tabId": { "type": "integer", "optional": true, "description": "The tab id, defined if type == 'page'." },
@@ -176,10 +187,9 @@
"description": "The debuggee that was detached."
},
{
- "type": "string",
+ "$ref": "DetachReason",
"name": "reason",
- "description": "Connection termination reason.",
- "enum": [ "target_closed", "canceled_by_user", "replaced_with_devtools" ]
+ "description": "Connection termination reason."
}
]
}
« no previous file with comments | « chrome/common/extensions/api/cookies.json ('k') | chrome/common/extensions/api/extension.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698