chrome/common/extensions/api/extension.json - Issue 1055673002: [Extensions API] Remove inline enums

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension.json

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/api/extension.json

diff --git a/chrome/common/extensions/api/extension.json b/chrome/common/extensions/api/extension.json

index b69b12e7c05f649763f69c94edc5996c0c93e4f9..c83f89eccaa6d3854bb879459318d26a59b968df 100644

--- a/chrome/common/extensions/api/extension.json

+++ b/chrome/common/extensions/api/extension.json

@@ -24,6 +24,14 @@

"description": "True for content scripts running inside incognito tabs, and for extension pages running inside an incognito process. The latter only applies to extensions with 'split' incognito_behavior."

}

+ "types": [

+ {

+ "id": "ViewType",

+ "type": "string",

+ "enum": ["tab", "notification", "popup"],

+ "description": "The type of extension view."

+ }

+ ],

"functions": [

{

"name": "sendRequest",

@@ -78,8 +86,7 @@

"optional": true,

"properties": {

"type": {

- "type": "string",

- "enum": ["tab", "notification", "popup"],

+ "$ref": "ViewType",

"optional": true,

"description": "The type of view to get. If omitted, returns all views (including background pages and tabs). Valid values: 'tab', 'notification', 'popup'."

« no previous file with comments | « chrome/common/extensions/api/debugger.json ('k') | chrome/common/extensions/api/history.json » ('j') | no next file with comments »