Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: chrome/common/extensions/api/chrome_web_view_internal.json

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/chrome_web_view_internal.json
diff --git a/chrome/common/extensions/api/chrome_web_view_internal.json b/chrome/common/extensions/api/chrome_web_view_internal.json
index 33e282c49b7873261b1b8b101f66183f234f583b..0797d47eca429946d4eac55d0932851413efc0f1 100644
--- a/chrome/common/extensions/api/chrome_web_view_internal.json
+++ b/chrome/common/extensions/api/chrome_web_view_internal.json
@@ -9,7 +9,7 @@
"compiler_options": {
"implemented_in": "chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.h"
},
- "dependencies": ["contextMenusInternal"],
+ "dependencies": ["contextMenusInternal", "contextMenus"],
"types": [
{
"id": "ContextMenuItem",
@@ -50,8 +50,7 @@
"name": "createProperties",
"properties": {
"type": {
- "type": "string",
- "enum": ["normal", "checkbox", "radio", "separator"],
+ "$ref": "contextMenus.ItemType",
"optional": true,
"description": "The type of menu item. Defaults to 'normal' if not specified."
},
@@ -73,13 +72,12 @@
"contexts": {
"type": "array",
"items": {
- "type": "string",
// |launcher| isn't actually supported, this is listed here so that we can build |contexts| using the same code from chrome.contextMenus API.
- "enum": ["all", "page", "frame", "selection", "link", "editable", "image", "video", "audio", "launcher", "browser_action", "page_action"]
+ "$ref": "contextMenus.ContextType"
},
"minItems": 1,
"optional": true,
- "description": "List of contexts this menu item will appear in. Defaults to ['page'] if not specified. Specifying ['all'] is equivalent to the combination of all other contexts except for 'launcher'. The 'launcher' context is not supported for <webview>."
+ "description": "List of contexts this menu item will appear in. Defaults to ['page'] if not specified."
},
"onclick": {
"type": "function",
@@ -152,8 +150,7 @@
"description": "The properties to update. Accepts the same values as the create function.",
"properties": {
"type": {
- "type": "string",
- "enum": ["normal", "checkbox", "radio", "separator"],
+ "$ref": "contextMenus.ItemType",
"optional": true
},
"title": {
@@ -167,13 +164,12 @@
"contexts": {
"type": "array",
"items": {
- "type": "string",
// |launcher| isn't actually supported, this is listed here so that we can build |contexts| using the same code from chrome.contextMenus API.
- "enum": ["all", "page", "frame", "selection", "link", "editable", "image", "video", "audio", "launcher", "browser_action", "page_action"]
+ "$ref": "contextMenus.ContextType"
},
"minItems": 1,
"optional": true,
- "description": "List of contexts this menu item will appear in. Defaults to ['page'] if not specified. Specifying ['all'] is equivalent to the combination of all other contexts except for 'launcher'. The 'launcher' context is not supported for <webview>."
+ "description": "List of contexts this menu item will appear in. Defaults to ['page'] if not specified."
},
"onclick": {
"type": "function",
« no previous file with comments | « chrome/common/extensions/api/bookmarks.json ('k') | chrome/common/extensions/api/chromeos_info_private.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698