chrome/common/extensions/api/bookmarks.json - Issue 1055673002: [Extensions API] Remove inline enums

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/bookmarks.json

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/activity_log_private.json ('k') | chrome/common/extensions/api/chrome_web_view_internal.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/bookmarks.json

diff --git a/chrome/common/extensions/api/bookmarks.json b/chrome/common/extensions/api/bookmarks.json

index c0c98b84e010913ec62dd88acb876a2bc0b85247..81b3a2af0401d6b90b37ff7643a273b557f5ca54 100644

--- a/chrome/common/extensions/api/bookmarks.json

+++ b/chrome/common/extensions/api/bookmarks.json

@@ -20,6 +20,12 @@

"types": [

{

+ "id": "BookmarkTreeNodeUnmodifiable",

+ "type": "string",

+ "enum": ["managed"],

+ "description": "Indicates the reason why this node is unmodifiable. The <var>managed</var> value indicates that this node was configured by the system administrator or by the custodian of a supervised user. Omitted if the node can be modified by the user and the extension (default)."

+ },

+ {

"id": "BookmarkTreeNode",

"type": "object",

"description": "A node (either a bookmark or a folder) in the bookmark tree. Child nodes are ordered within their parent folder.",

@@ -60,8 +66,7 @@

"description": "When the contents of this folder last changed, in milliseconds since the epoch."

"unmodifiable": {

- "type": "string",

- "enum": ["managed"],

+ "$ref": "BookmarkTreeNodeUnmodifiable",

"optional": true,

"description": "Indicates the reason why this node is unmodifiable. The <var>managed</var> value indicates that this node was configured by the system administrator or by the custodian of a supervised user. Omitted if the node can be modified by the user and the extension (default)."