chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc - Issue 1055673002: [Extensions API] Remove inline enums

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc ('k') | chrome/browser/extensions/api/content_settings/content_settings_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc

diff --git a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc

index 2f6d5faed96ad5aba0c0101b6df832aef835072e..bca84deaedc4329b310bc6eb2a3bea43a624b0fd 100644

--- a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc

+++ b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc

@@ -118,7 +118,8 @@ TEST_F(ExtensionBookmarksTest, GetModifiableNode) {

EXPECT_EQ("Digg", tree->title);

ASSERT_TRUE(tree->url);

EXPECT_EQ("http://www.reddit.com/", *tree->url);

- EXPECT_EQ(BookmarkTreeNode::UNMODIFIABLE_NONE, tree->unmodifiable);

+ EXPECT_EQ(api::bookmarks::BOOKMARK_TREE_NODE_UNMODIFIABLE_NONE,

+ tree->unmodifiable);

}

TEST_F(ExtensionBookmarksTest, GetManagedNode) {

@@ -134,7 +135,8 @@ TEST_F(ExtensionBookmarksTest, GetManagedNode) {

false)); // Only folders.

EXPECT_EQ("Chromium", tree->title);

EXPECT_EQ("http://www.chromium.org/", *tree->url);

- EXPECT_EQ(BookmarkTreeNode::UNMODIFIABLE_MANAGED, tree->unmodifiable);

+ EXPECT_EQ(api::bookmarks::BOOKMARK_TREE_NODE_UNMODIFIABLE_MANAGED,

+ tree->unmodifiable);

}

TEST_F(ExtensionBookmarksTest, RemoveNodeInvalidId) {