Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc

Issue 1055673002: [Extensions API] Remove inline enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h" 5 #include "chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 111
112 TEST_F(ExtensionBookmarksTest, GetModifiableNode) { 112 TEST_F(ExtensionBookmarksTest, GetModifiableNode) {
113 scoped_ptr<BookmarkTreeNode> tree( 113 scoped_ptr<BookmarkTreeNode> tree(
114 GetBookmarkTreeNode(client_, 114 GetBookmarkTreeNode(client_,
115 node_, 115 node_,
116 false, // Recurse. 116 false, // Recurse.
117 false)); // Only folders. 117 false)); // Only folders.
118 EXPECT_EQ("Digg", tree->title); 118 EXPECT_EQ("Digg", tree->title);
119 ASSERT_TRUE(tree->url); 119 ASSERT_TRUE(tree->url);
120 EXPECT_EQ("http://www.reddit.com/", *tree->url); 120 EXPECT_EQ("http://www.reddit.com/", *tree->url);
121 EXPECT_EQ(BookmarkTreeNode::UNMODIFIABLE_NONE, tree->unmodifiable); 121 EXPECT_EQ(api::bookmarks::BOOKMARK_TREE_NODE_UNMODIFIABLE_NONE,
122 tree->unmodifiable);
122 } 123 }
123 124
124 TEST_F(ExtensionBookmarksTest, GetManagedNode) { 125 TEST_F(ExtensionBookmarksTest, GetManagedNode) {
125 const BookmarkNode* managed_bookmark = 126 const BookmarkNode* managed_bookmark =
126 model_->AddURL(client_->managed_node(), 127 model_->AddURL(client_->managed_node(),
127 0, 128 0,
128 base::ASCIIToUTF16("Chromium"), 129 base::ASCIIToUTF16("Chromium"),
129 GURL("http://www.chromium.org/")); 130 GURL("http://www.chromium.org/"));
130 scoped_ptr<BookmarkTreeNode> tree( 131 scoped_ptr<BookmarkTreeNode> tree(
131 GetBookmarkTreeNode(client_, 132 GetBookmarkTreeNode(client_,
132 managed_bookmark, 133 managed_bookmark,
133 false, // Recurse. 134 false, // Recurse.
134 false)); // Only folders. 135 false)); // Only folders.
135 EXPECT_EQ("Chromium", tree->title); 136 EXPECT_EQ("Chromium", tree->title);
136 EXPECT_EQ("http://www.chromium.org/", *tree->url); 137 EXPECT_EQ("http://www.chromium.org/", *tree->url);
137 EXPECT_EQ(BookmarkTreeNode::UNMODIFIABLE_MANAGED, tree->unmodifiable); 138 EXPECT_EQ(api::bookmarks::BOOKMARK_TREE_NODE_UNMODIFIABLE_MANAGED,
139 tree->unmodifiable);
138 } 140 }
139 141
140 TEST_F(ExtensionBookmarksTest, RemoveNodeInvalidId) { 142 TEST_F(ExtensionBookmarksTest, RemoveNodeInvalidId) {
141 int64 invalid_id = model_->next_node_id(); 143 int64 invalid_id = model_->next_node_id();
142 std::string error; 144 std::string error;
143 EXPECT_FALSE(RemoveNode(model_, client_, invalid_id, true, &error)); 145 EXPECT_FALSE(RemoveNode(model_, client_, invalid_id, true, &error));
144 EXPECT_EQ(keys::kNoNodeError, error); 146 EXPECT_EQ(keys::kNoNodeError, error);
145 } 147 }
146 148
147 TEST_F(ExtensionBookmarksTest, RemoveNodePermanent) { 149 TEST_F(ExtensionBookmarksTest, RemoveNodePermanent) {
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 string_value.clear(); 232 string_value.clear();
231 EXPECT_FALSE(dictionary_value->GetString("some_key1", &string_value)); 233 EXPECT_FALSE(dictionary_value->GetString("some_key1", &string_value));
232 EXPECT_EQ("", string_value); 234 EXPECT_EQ("", string_value);
233 EXPECT_TRUE(dictionary_value->GetString("some_key2", &string_value)); 235 EXPECT_TRUE(dictionary_value->GetString("some_key2", &string_value));
234 EXPECT_EQ("some_value2", string_value); 236 EXPECT_EQ("some_value2", string_value);
235 237
236 } 238 }
237 239
238 } // namespace bookmark_api_helpers 240 } // namespace bookmark_api_helpers
239 } // namespace extensions 241 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698