Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1055663003: Check if Fragment is attached in onClick (Closed)

Created:
5 years, 8 months ago by aruslan
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check if Fragment is attached in onClick We still don't have sensible explanation, but the current theory is that the Fragment-related transaction creates a race wrt onClick and Detach. BUG=467846 Committed: https://crrev.com/0d4c89148c0f10a518805aea0d8c6c70bd490900 Cr-Commit-Position: refs/heads/master@{#323846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aruslan
PTAL, thanks!
5 years, 8 months ago (2015-04-03 15:54:46 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 8 months ago (2015-04-03 23:03:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055663003/1
5 years, 8 months ago (2015-04-03 23:04:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-03 23:29:12 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 23:30:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d4c89148c0f10a518805aea0d8c6c70bd490900
Cr-Commit-Position: refs/heads/master@{#323846}

Powered by Google App Engine
This is Rietveld 408576698