Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3863)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java

Issue 1055663003: Check if Fragment is attached in onClick (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java
index 368d6a5a5a684bf93425fc7231fad22b0a142ace..9ad76f20f2924a51fa36c81e6fd1a8a3491a5b09 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java
@@ -67,6 +67,7 @@ public class ToSAndUMAFirstRunFragment extends FirstRunPage {
ClickableSpan clickableTermsSpan = new ClickableSpan() {
@Override
public void onClick(View widget) {
+ if (!isAdded()) return;
getPageDelegate().showEmbedContentViewActivity(R.string.terms_of_service_title,
R.string.chrome_terms_of_service_url);
}
@@ -75,6 +76,7 @@ public class ToSAndUMAFirstRunFragment extends FirstRunPage {
ClickableSpan clickablePrivacySpan = new ClickableSpan() {
@Override
public void onClick(View widget) {
+ if (!isAdded()) return;
getPageDelegate().showEmbedContentViewActivity(R.string.privacy_notice_title,
R.string.chrome_privacy_notice_url);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698