Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3933)

Unified Diff: extensions/browser/extension_prefs.cc

Issue 1055453007: Added CHECKs for null pointers in ChromeAppSorting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added CHECK(this) just to make sure that ExtensionPrefs is non-null. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/app_sorting.h ('k') | extensions/browser/null_app_sorting.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_prefs.cc
diff --git a/extensions/browser/extension_prefs.cc b/extensions/browser/extension_prefs.cc
index c4f7da2e79013c6ba7d1be3ff6de6c4d5903cb70..c7409b339456bcff352d858e0f20a33dbd7f6ef1 100644
--- a/extensions/browser/extension_prefs.cc
+++ b/extensions/browser/extension_prefs.cc
@@ -1866,7 +1866,11 @@ ExtensionPrefs::ExtensionPrefs(
app_sorting_(app_sorting.Pass()),
time_provider_(time_provider.Pass()),
extensions_disabled_(extensions_disabled) {
+ // TODO(mgiuca): Added these checks to try and diagnose
+ // http://crbug.com/476648. Remove them after the investigation is concluded.
+ CHECK(this);
app_sorting_->SetExtensionScopedPrefs(this);
+ app_sorting_->CheckExtensionScopedPrefs();
MakePathsRelative();
// Ensure that any early observers are watching before prefs are initialized.
« no previous file with comments | « extensions/browser/app_sorting.h ('k') | extensions/browser/null_app_sorting.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698