Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1652)

Unified Diff: extensions/browser/app_sorting.h

Issue 1055453007: Added CHECKs for null pointers in ChromeAppSorting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added CHECK(this) just to make sure that ExtensionPrefs is non-null. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/chrome_app_sorting.cc ('k') | extensions/browser/extension_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/app_sorting.h
diff --git a/extensions/browser/app_sorting.h b/extensions/browser/app_sorting.h
index 39d50dcd16c45c4393ac9dfc054a9b498d88a7d9..bc6378db30536d1643bbacafee4d06126655efde 100644
--- a/extensions/browser/app_sorting.h
+++ b/extensions/browser/app_sorting.h
@@ -27,11 +27,17 @@ class AppSorting {
// caller.
virtual void SetExtensionScopedPrefs(ExtensionScopedPrefs* prefs) = 0;
+ // CHECKs that SetExtensionScopedPrefs has been called with a non-null object.
+ // TODO(mgiuca): Added this to try and diagnose http://crbug.com/476648.
+ // Remove it after the investigation is concluded.
+ virtual void CheckExtensionScopedPrefs() const = 0;
+
// Sets up the ExtensionSyncService to inform of changes that require syncing.
virtual void SetExtensionSyncService(
ExtensionSyncService* extension_sync_service) = 0;
// Properly initializes internal values that require |extension_ids|.
+ // SetExtensionScopedPrefs must have been called prior to this.
virtual void Initialize(const extensions::ExtensionIdList& extension_ids) = 0;
// Resolves any conflicts the might be created as a result of syncing that
« no previous file with comments | « chrome/browser/extensions/chrome_app_sorting.cc ('k') | extensions/browser/extension_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698