Issue 1055243002: Revert "Revert "First iteration on custom layout.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1055243002: Revert "Revert "First iteration on custom layout."" (Closed)

Created:
5 years, 8 months ago by ojan

Modified:
5 years, 8 months ago

Reviewers:

CC:
abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Revert "Revert "First iteration on custom layout."" This reverts commit 44cf3b689cda2632fa649e2cd3fdbfcb7174f352. https://codereview.chromium.org/1060443002 fixes the cause of the test breakage. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0fc849bd2287fbcd2723e325b4fdcf7ea14249ab

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+182 lines, -0 lines)			Patch
M	sky/engine/core/core.gni	View	3 chunks	+4 lines, -0 lines	0 comments	Download
M	sky/engine/core/dom/Element.h	View	3 chunks	+17 lines, -0 lines	0 comments	Download
M	sky/engine/core/dom/Element.cpp	View	3 chunks	+66 lines, -0 lines	0 comments	Download
M	sky/engine/core/dom/Element.idl	View	2 chunks	+7 lines, -0 lines	0 comments	Download
A	sky/engine/core/layout/LayoutCallback.h	View	1 chunk	+18 lines, -0 lines	0 comments	Download
A +	sky/engine/core/layout/LayoutCallback.idl	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	sky/engine/core/rendering/RenderCustomLayout.h	View	1 chunk	+24 lines, -0 lines	0 comments	Download
A	sky/engine/core/rendering/RenderCustomLayout.cpp	View	1 chunk	+42 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

ojan

5 years, 8 months ago (2015-04-02 22:17:14 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0fc849bd2287fbcd2723e325b4fdcf7ea14249ab (presubmit successful).