Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1060443002: Remove x,y,width,height from HTMLImageElement. (Closed)

Created:
5 years, 8 months ago by ojan
Modified:
5 years, 8 months ago
Reviewers:
eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove x,y,width,height from HTMLImageElement. This conflicts with adding them to HTMLElement for custom layout. I grepped the codebase and couldn't find any uses of these. The big thing we lose here is a way to set width/height on an image that automatically maintains aspect ratio, but that's something we should move into a custom layout method anyways. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b508ec15783c87289a7f1e27bc487e46cef64494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M sky/engine/core/html/HTMLImageElement.idl View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
eseidel
Do you want to remove the c++ too? lgtm
5 years, 8 months ago (2015-04-02 22:13:07 UTC) #2
ojan
On 2015/04/02 at 22:13:07, eseidel wrote: > Do you want to remove the c++ too? ...
5 years, 8 months ago (2015-04-02 22:13:51 UTC) #3
ojan
5 years, 8 months ago (2015-04-02 22:15:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b508ec15783c87289a7f1e27bc487e46cef64494 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698