Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 1055203002: Fix the RenderFrameProxyHost mop-up logic in RenderFrameHostManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: EXPECT_ instead of ASSERT_ Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_manager.h
diff --git a/content/browser/frame_host/render_frame_host_manager.h b/content/browser/frame_host/render_frame_host_manager.h
index 89eeef69f9d549dc85a644eb8021a57176ce91d2..ead00324c76d324e7f33eaaddca0121dd96df1e3 100644
--- a/content/browser/frame_host/render_frame_host_manager.h
+++ b/content/browser/frame_host/render_frame_host_manager.h
@@ -577,10 +577,12 @@ class CONTENT_EXPORT RenderFrameHostManager : public NotificationObserver {
void MoveToPendingDeleteHosts(
scoped_ptr<RenderFrameHostImpl> render_frame_host);
- // Shutdown all RenderFrameProxyHosts in a SiteInstance. This is called to
- // shutdown frames when all the frames in a SiteInstance are confirmed to be
- // swapped out.
- void ShutdownRenderFrameProxyHostsInSiteInstance(int32 site_instance_id);
+ // If |render_frame_host| is the last remaining active frame in its
+ // SiteInstance, this will shutdown all the RenderFrameProxyHosts in the
+ // SiteInstance. This is appropriate if |render_frame_host| is about to be
+ // destroyed.
+ void ShutdownProxiesIfLastActiveFrameInSiteInstance(
+ RenderFrameHostImpl* render_frame_host);
// Helper method to terminate the pending RenderFrameHost. The frame may be
// deleted immediately, or it may be kept around in hopes of later reuse.
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698