Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 1055203002: Fix the RenderFrameProxyHost mop-up logic in RenderFrameHostManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: EXPECT_ instead of ASSERT_ Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 559 matching lines...) Expand 10 before | Expand all | Expand 10 after
570 570
571 // Discards a RenderFrameHost that was never made active (for active ones 571 // Discards a RenderFrameHost that was never made active (for active ones
572 // SwapOutOldFrame is used instead). 572 // SwapOutOldFrame is used instead).
573 void DiscardUnusedFrame(scoped_ptr<RenderFrameHostImpl> render_frame_host); 573 void DiscardUnusedFrame(scoped_ptr<RenderFrameHostImpl> render_frame_host);
574 574
575 // Holds |render_frame_host| until it can be deleted when its swap out ACK 575 // Holds |render_frame_host| until it can be deleted when its swap out ACK
576 // arrives. 576 // arrives.
577 void MoveToPendingDeleteHosts( 577 void MoveToPendingDeleteHosts(
578 scoped_ptr<RenderFrameHostImpl> render_frame_host); 578 scoped_ptr<RenderFrameHostImpl> render_frame_host);
579 579
580 // Shutdown all RenderFrameProxyHosts in a SiteInstance. This is called to 580 // If |render_frame_host| is the last remaining active frame in its
581 // shutdown frames when all the frames in a SiteInstance are confirmed to be 581 // SiteInstance, this will shutdown all the RenderFrameProxyHosts in the
582 // swapped out. 582 // SiteInstance. This is appropriate if |render_frame_host| is about to be
583 void ShutdownRenderFrameProxyHostsInSiteInstance(int32 site_instance_id); 583 // destroyed.
584 void ShutdownProxiesIfLastActiveFrameInSiteInstance(
585 RenderFrameHostImpl* render_frame_host);
584 586
585 // Helper method to terminate the pending RenderFrameHost. The frame may be 587 // Helper method to terminate the pending RenderFrameHost. The frame may be
586 // deleted immediately, or it may be kept around in hopes of later reuse. 588 // deleted immediately, or it may be kept around in hopes of later reuse.
587 void CancelPending(); 589 void CancelPending();
588 590
589 // Clears pending_render_frame_host_, returning it to the caller for disposal. 591 // Clears pending_render_frame_host_, returning it to the caller for disposal.
590 scoped_ptr<RenderFrameHostImpl> UnsetPendingRenderFrameHost(); 592 scoped_ptr<RenderFrameHostImpl> UnsetPendingRenderFrameHost();
591 593
592 // Helper method to set the active RenderFrameHost. Returns the old 594 // Helper method to set the active RenderFrameHost. Returns the old
593 // RenderFrameHost and updates counts. 595 // RenderFrameHost and updates counts.
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
703 bool should_reuse_web_ui_; 705 bool should_reuse_web_ui_;
704 706
705 base::WeakPtrFactory<RenderFrameHostManager> weak_factory_; 707 base::WeakPtrFactory<RenderFrameHostManager> weak_factory_;
706 708
707 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager); 709 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager);
708 }; 710 };
709 711
710 } // namespace content 712 } // namespace content
711 713
712 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 714 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698