Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1055173003: Remove unused ThumbnailDatabase::UpdateIconMapping() and ThumbnailDatabase::CloneIconMappings() (Closed)

Created:
5 years, 8 months ago by pkotwicz
Modified:
5 years, 8 months ago
Reviewers:
pkotwicz1, sky
CC:
chromium-reviews, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused ThumbnailDatabase::UpdateIconMapping() and ThumbnailDatabase::CloneIconMappings() BUG=None TEST=None Committed: https://crrev.com/e66a6984230f0005a184edae8c03ea7f46a1f8a4 Cr-Commit-Position: refs/heads/master@{#324267}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -222 lines) Patch
M chrome/browser/history/history_backend_unittest.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M chrome/browser/history/thumbnail_database_unittest.cc View 2 chunks +0 lines, -93 lines 0 comments Download
M components/favicon/core/favicon_service.h View 1 chunk +0 lines, -7 lines 0 comments Download
M components/favicon/core/favicon_service.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/history/core/browser/history_backend.h View 2 chunks +0 lines, -4 lines 0 comments Download
M components/history/core/browser/history_backend.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M components/history/core/browser/history_service.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/history/core/browser/history_service.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M components/history/core/browser/thumbnail_database.h View 2 chunks +0 lines, -10 lines 0 comments Download
M components/history/core/browser/thumbnail_database.cc View 2 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
pkotwicz
sky@ PTAL
5 years, 8 months ago (2015-04-04 03:57:46 UTC) #4
sky
LGTM
5 years, 8 months ago (2015-04-08 17:31:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055173003/40001
5 years, 8 months ago (2015-04-08 17:34:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 8 months ago (2015-04-08 19:20:39 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 19:22:20 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e66a6984230f0005a184edae8c03ea7f46a1f8a4
Cr-Commit-Position: refs/heads/master@{#324267}

Powered by Google App Engine
This is Rietveld 408576698