Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: components/history/core/browser/thumbnail_database.cc

Issue 1055173003: Remove unused ThumbnailDatabase::UpdateIconMapping() and ThumbnailDatabase::CloneIconMappings() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/history/core/browser/thumbnail_database.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/history/core/browser/thumbnail_database.cc
diff --git a/components/history/core/browser/thumbnail_database.cc b/components/history/core/browser/thumbnail_database.cc
index 45bf29909501786c766f88b34faf5f0f0d246a98..e1579f9afb46ed8f1b7c8264f3c98e400c5bba61 100644
--- a/components/history/core/browser/thumbnail_database.cc
+++ b/components/history/core/browser/thumbnail_database.cc
@@ -1035,16 +1035,6 @@ IconMappingID ThumbnailDatabase::AddIconMapping(
return db_.GetLastInsertRowId();
}
-bool ThumbnailDatabase::UpdateIconMapping(IconMappingID mapping_id,
- favicon_base::FaviconID icon_id) {
- sql::Statement statement(db_.GetCachedStatement(SQL_FROM_HERE,
- "UPDATE icon_mapping SET icon_id=? WHERE id=?"));
- statement.BindInt64(0, icon_id);
- statement.BindInt64(1, mapping_id);
-
- return statement.Run();
-}
-
bool ThumbnailDatabase::DeleteIconMappings(const GURL& page_url) {
sql::Statement statement(db_.GetCachedStatement(SQL_FROM_HERE,
"DELETE FROM icon_mapping WHERE page_url = ?"));
@@ -1070,29 +1060,6 @@ bool ThumbnailDatabase::HasMappingFor(favicon_base::FaviconID id) {
return statement.Step();
}
-bool ThumbnailDatabase::CloneIconMappings(const GURL& old_page_url,
- const GURL& new_page_url) {
- sql::Statement statement(db_.GetCachedStatement(SQL_FROM_HERE,
- "SELECT icon_id FROM icon_mapping "
- "WHERE page_url=?"));
- if (!statement.is_valid())
- return false;
-
- // Do nothing if there are existing bindings
- statement.BindString(0, URLDatabase::GURLToDatabaseURL(new_page_url));
- if (statement.Step())
- return true;
-
- statement.Assign(db_.GetCachedStatement(SQL_FROM_HERE,
- "INSERT INTO icon_mapping (page_url, icon_id) "
- "SELECT ?, icon_id FROM icon_mapping "
- "WHERE page_url = ?"));
-
- statement.BindString(0, URLDatabase::GURLToDatabaseURL(new_page_url));
- statement.BindString(1, URLDatabase::GURLToDatabaseURL(old_page_url));
- return statement.Run();
-}
-
bool ThumbnailDatabase::InitIconMappingEnumerator(
favicon_base::IconType type,
IconMappingEnumerator* enumerator) {
« no previous file with comments | « components/history/core/browser/thumbnail_database.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698